After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704791 - Check return value of g_dbus_connection_register_object()
Check return value of g_dbus_connection_register_object()
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-24 09:14 UTC by David King
Modified: 2013-07-24 13:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description David King 2013-07-24 09:14:01 UTC 
As noticed by Bastien in bug 692771, comment #20, some uses of g_dbus_connection_register_object() do not check the return value, where 0 indicates an error. The settings manager code is one such example:

gnome-settings-daemon/gnome-settings-manager.c:358
Comment 1 Bastien Nocera 2013-07-24 13:18:55 UTC 
commit f8bcc020c630aa8d8ecd1a7f5acda564fbd43d15
Author: Bastien Nocera <hadess@hadess.net>
Date:   Wed Jul 24 15:08:39 2013 +0200

    main: Use GCancellable
    
    And check for g_dbus_connection_register_object()'s retval.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=704791