After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704768 - bad hints in documentation will hardcode $PATH in .bashrc
bad hints in documentation will hardcode $PATH in .bashrc
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
: 673214 708008 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-07-23 20:57 UTC by Allison Karlitskaya (desrt)
Modified: 2016-01-27 15:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
doc: Add missing quote to PATH adjustment (981 bytes, patch)
2014-03-08 12:45 UTC, Volker Sobek (weld) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2013-07-23 20:57:20 UTC 
The documentation advises the user to type this during their setup of jhbuild:

$ echo PATH=$PATH:~/.local/bin >> ~/.bashrc

This is quite bad.  The user's $PATH will be taken at the time they type this (outside of jhbuild) and hardcoded into their .bashrc.

When running 'jhbuild shell', jhbuild will set the path properly, then the bashrc will run and erase the path again, replacing it with the previously-hardcoded value.

We should _not_ be advising people to modify their bashrc, but rather we should install into a path that's already universally in people's path: ~/bin.
Comment 1 Murray Cumming 2013-09-13 07:58:47 UTC 
*** Bug 708008 has been marked as a duplicate of this bug. ***
Comment 2 Frederic Peters 2013-11-23 17:38:13 UTC 
This fixes the documentation part.

commit 9046bdbc6b19567fbdda0fa8648dae06eeace2aa
Author: Frédéric Péters <fpeters@0d.be>
Date:   Sat Nov 23 18:36:59 2013 +0100

    add missing quote in PATH adjustement documentation (GNOME bug 704768)
Comment 3 Volker Sobek (weld) 2014-03-08 12:45:34 UTC 
Created attachment 271305 [details] [review]
doc: Add missing quote to PATH adjustment

Fixing the same issue as commit 9046bdbc6b in another place in the
documentation as well.
Comment 4 Frederic Peters 2014-03-08 13:52:30 UTC 
Attachment 271305 [details] pushed as 8ec6232 - doc: Add missing quote to PATH adjustment
Comment 5 Frederic Peters 2016-01-27 15:37:05 UTC 
*** Bug 673214 has been marked as a duplicate of this bug. ***