After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704752 - Make window a template and other stuff
Make window a template and other stuff
Status: RESOLVED FIXED
Product: devhelp
Classification: Applications
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: devhelp-maint
devhelp-maint
: 701966 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-07-23 16:02 UTC by Ignacio Casal Quinteiro (nacho)
Modified: 2013-07-24 10:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
template (19.58 KB, patch)
2013-07-23 16:02 UTC, Ignacio Casal Quinteiro (nacho) 		none Details | Review
close button (3.35 KB, patch)
2013-07-23 16:02 UTC, Ignacio Casal Quinteiro (nacho) 		none Details | Review
icon name (1.23 KB, patch)
2013-07-23 16:02 UTC, Ignacio Casal Quinteiro (nacho) 		none Details | Review
gedit close button (8.61 KB, patch)
2013-07-23 16:03 UTC, Ignacio Casal Quinteiro (nacho) 		none Details | Review
sidebar box (1.62 KB, patch)
2013-07-23 18:31 UTC, Ignacio Casal Quinteiro (nacho) 		none Details | Review
sidebar init (9.11 KB, patch)
2013-07-23 18:44 UTC, Ignacio Casal Quinteiro (nacho) 		none Details | Review
booktree private (5.89 KB, patch)
2013-07-24 08:49 UTC, Ignacio Casal Quinteiro (nacho) 		none Details | Review

Description Ignacio Casal Quinteiro (nacho) 2013-07-23 16:02:00 UTC 
Created attachment 249913 [details] [review]
template

SSIA
Comment 1 Ignacio Casal Quinteiro (nacho) 2013-07-23 16:02:20 UTC 
Created attachment 249914 [details] [review]
close button

adds a close button to the window
Comment 2 Ignacio Casal Quinteiro (nacho) 2013-07-23 16:02:40 UTC 
Created attachment 249915 [details] [review]
icon name

Set icon name in ui file
Comment 3 Ignacio Casal Quinteiro (nacho) 2013-07-23 16:03:11 UTC 
Created attachment 249916 [details] [review]
gedit close button

This is a widget we made for the tab close button
Comment 4 Ignacio Casal Quinteiro (nacho) 2013-07-23 18:31:28 UTC 
Created attachment 249929 [details] [review]
sidebar box

Make sidebar inherit from GtkBox
Comment 5 Ignacio Casal Quinteiro (nacho) 2013-07-23 18:44:57 UTC 
Created attachment 249932 [details] [review]
sidebar init

Move some of the stuff from new to init
Comment 6 Ignacio Casal Quinteiro (nacho) 2013-07-24 08:49:40 UTC 
Created attachment 250006 [details] [review]
booktree private

Use G_DEFINE_TYPE_WITH_PRIVATE for booktree
Comment 7 Aleksander Morgado 2013-07-24 10:19:42 UTC 
Feel free to merge the 'wip/wintemplate' branch once fixed the things discussed in irc.
Comment 8 Aleksander Morgado 2013-07-24 10:21:52 UTC 
*** Bug 701966 has been marked as a duplicate of this bug. ***
Comment 9 Ignacio Casal Quinteiro (nacho) 2013-07-24 10:25:07 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.