After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704629 - Program name changes in dosfstools 3.0.18+ break FAT16/32 support
Program name changes in dosfstools 3.0.18+ break FAT16/32 support
Status: RESOLVED FIXED
Product: gparted
Classification: Other
Component: application
0.16.1
Other Linux
: Normal normal
: ---
Assigned To: gparted maintainers alias
gparted maintainers alias
Depends on:
Blocks:
 
 
Reported: 2013-07-21 01:34 UTC by Curtis Gedak
Modified: 2013-09-18 16:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Recognise newer dosfstools program names (v1) (4.21 KB, patch)
2013-07-25 22:49 UTC, Mike Fleetwood
none Details | Review

Description Curtis Gedak 2013-07-21 01:34:37 UTC
It appears that there was a change in dosfstools program names introduced in dosfstools 3.0.18.

See the following commit:

Renaming tools to sane namespace and keeping legacy symlinks in place.
http://daniel-baumann.ch/gitweb/?p=software/dosfstools.git;a=commit;h=ea8f712730ceeb88560cbd5beeea368a28befab2

dosfslabel becomes fatlabel,
dosfsck becomes fsck.fat,
and mkdosfs becomes mkfs.fat.

Since GParted uses the older names from dosfstools 3.0.17 and earlier (dosfsck and mkdosfs), this name change breaks GParted FAT16 and FAT32 support.


A temporary work around would be to create symbolic links for the old names.

For example, something like the following commands should work:

    sudo ln -s /sbin/fsck.fat /sbin/dosfsck
    sudo ln -s /sbin/mkfs.fat /sbin/mkdosfs

The initial report of this problem can be found at the following link:

Debian Bug report logs - #717408
gparted: Unable to create fat16/fat32 using dosfstools 3.0.22-1
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=717408
Comment 1 Joan Lledó 2013-07-23 20:38:28 UTC
I've just read the commit you've linked and you're right, but it seems they've  created legacy symlinks. Look at the commit title:

"Renaming tools to sane namespace and keeping legacy symlinks in place."

And if you check the differences in the Makefile you can find:

-       ln -sf dosfsck $(DESTDIR)/$(SBINDIR)/fsck.msdos
-       ln -sf dosfsck $(DESTDIR)/$(SBINDIR)/fsck.vfat
-       ln -sf mkdosfs $(DESTDIR)/$(SBINDIR)/mkfs.msdos
-       ln -sf mkdosfs $(DESTDIR)/$(SBINDIR)/mkfs.vfat
+       # legacy symlinks
+       ln -sf fatlabel $(DESTDIR)/$(SBINDIR)/dosfslabel
+
+       ln -sf fsck.fat $(DESTDIR)/$(SBINDIR)/dosfsck
+       ln -sf fsck.fat $(DESTDIR)/$(SBINDIR)/fsck.msdos
+       ln -sf fsck.fat $(DESTDIR)/$(SBINDIR)/fsck.vfat
+
+       ln -sf mkfs.fat $(DESTDIR)/$(SBINDIR)/mkdosfs
+       ln -sf mkfs.fat $(DESTDIR)/$(SBINDIR)/mkfs.msdos
+       ln -sf mkfs.fat $(DESTDIR)/$(SBINDIR)/mkfs.vfat
Comment 2 Mike Fleetwood 2013-07-24 07:06:42 UTC
Unfortunately the bug was initially raised on Debian using the
experimental version of the dosfstools package and that doesn't include
the backward compatible symbolic links, hence the need to create the
symbolic links manually.

Filelist of Debian dosfstools 3.0.22-1 (experimental) package on i386
http://packages.debian.org/experimental/i386/dosfstools/filelist
Comment 3 Mike Fleetwood 2013-07-25 22:49:31 UTC
Created attachment 250150 [details] [review]
Recognise newer dosfstools program names (v1)

Hi Curtis,

Here's a patch to recognise the the new dosfstools names first and the
old names second.

Thanks,
Mike
Comment 4 Curtis Gedak 2013-07-27 01:16:08 UTC
Thank you Mike for the patch.  I should have time to review it this weekend.

Curtis
Comment 5 Curtis Gedak 2013-07-27 17:43:16 UTC
Thank you Mike for making the commit description clear and developing a good solution for the dosfstools name changes.

The patch in comment #3 looks good to me and worked perfectly in all of my tests.

This patch has been committed to the git repository for inclusion in the next release of GParted.

The relevant git commit can be viewed at the following link:

Recognise new dosfstools program names (#704629)
https://git.gnome.org/browse/gparted/commit/?id=1ae03dee953f512c0c664369db2d5e5db80b4058
Comment 6 Curtis Gedak 2013-09-18 16:52:53 UTC
The patch to address this report has been included in GParted 0.16.2 released on September 18, 2013.