After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704624 - Silence automake warning
Silence automake warning
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-20 22:40 UTC by Stefano Facchini
Modified: 2013-07-22 19:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Silence automake warning (770 bytes, patch)
2013-07-20 22:40 UTC, Stefano Facchini 		committed Details | Review
Fix srcdir != builddir (1.07 KB, patch)
2013-07-20 22:40 UTC, Stefano Facchini 		committed Details | Review

Description Stefano Facchini 2013-07-20 22:40:12 UTC 
This one should have been really in the glib resource framework patch
Comment 1 Stefano Facchini 2013-07-20 22:40:14 UTC 
Created attachment 249723 [details] [review]
Silence automake warning

Silence a warning about $(shell) being non-POSIX
Comment 2 Stefano Facchini 2013-07-20 22:40:51 UTC 
Created attachment 249724 [details] [review]
Fix srcdir != builddir

... and this one, too
Comment 3 Robert Roth 2013-07-22 19:39:27 UTC 
While reviewing this I have found that make distcheck complains about gsm.gresource.xml file not found quite a few times (in fact I have just found that it did complain even before these patches). Should gsm.gresource.xml put in EXTRA_DIST? Regardless of this make distcheck completes and the tar.xz is built with the gresource.xml included, but i would like to keep it error-free.
Comment 4 Robert Roth 2013-07-22 19:50:03 UTC 
Sorry, disregard my comment :) I have applied the patch from 704623 and commented on this issue :)) Both patches apply and work fine.
Comment 5 Robert Roth 2013-07-22 19:51:41 UTC 
Attachment 249723 [details] pushed as cde25dd - Silence automake warning
Attachment 249724 [details] pushed as 081cad4 - Fix srcdir != builddir