After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704606 - Map "Easy" missing in PO/POT
Map "Easy" missing in PO/POT
Status: RESOLVED FIXED
Product: gnome-mahjongg
Classification: Applications
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: gnome-mahjongg-maint
gnome-mahjongg-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-20 13:58 UTC by Marek Černocký
Modified: 2013-09-06 19:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Mark "Easy" string as translatable (753 bytes, patch)
2013-09-06 10:05 UTC, Daniel Mustieles
none Details | Review
Mark Easy map name as translatable (1.59 KB, patch)
2013-09-06 13:10 UTC, Michael Catanzaro
committed Details | Review

Description Marek Černocký 2013-07-20 13:58:19 UTC
Map name "Easy" is missing as translateable.
Comment 1 André Klapper 2013-07-20 22:15:46 UTC
Wild guess: Change https://git.gnome.org/browse/gnome-mahjongg/tree/data/org.gnome.gnome-mahjongg.gschema.xml.in#n13
to <_default>Easy</_default>?
Comment 2 Daniel Mustieles 2013-09-06 10:05:36 UTC
Created attachment 254240 [details] [review]
Mark "Easy" string as translatable
Comment 3 Marek Černocký 2013-09-06 11:36:19 UTC
No. It's unfortunately more complicated.

"Easy" is missing in data/translatable_game_names.h It's easy add line:
NC_("mahjongg map name", "Easy")

But application stores current map in dconf as translated name. It's stupid.
- default value is Easy and if you have non-English locale, this value is invalid
- if you change your locale, current value becomes invalid
Schema should store English names.
Comment 4 Michael Catanzaro 2013-09-06 13:10:44 UTC
Created attachment 254247 [details] [review]
Mark Easy map name as translatable

We additionally need to store only the untranslated name in gsettings,
as we do with the non-builtin maps.
Comment 5 Michael Catanzaro 2013-09-06 13:12:57 UTC
Marek, can you sanity-check this for me please?  I'm not familiar with the process for adding new string translations, so I haven't tested to make sure this actually works.
Comment 6 André Klapper 2013-09-06 13:26:50 UTC
Testing: Apply the patch, go to /po, run "intltool-update -p", open the .pot file to see if the string is included. 
With regard to merging the patch into the codebase: Merging "forgotten" strings only requires announcing to gnome-i18n@, see https://wiki.gnome.org/TranslationProject/HandlingStringFreezes
Comment 7 Michael Catanzaro 2013-09-06 19:37:25 UTC
Right; we also needed to make sure the translated map name wasn't being used in gsettings, so I learned how to use -d to merge po files.  It does seem fixed so I'll push this now.  Thanks everyone!

Attachment 254247 [details] pushed as 6b84b2c - Mark Easy map name as translatable