After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704605 - letters are not aligned in board numbering in 3D view
letters are not aligned in board numbering in 3D view
Status: RESOLVED FIXED
Product: gnome-chess
Classification: Applications
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Michael Catanzaro
gnome-chess-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-20 13:12 UTC by Adam Dingle
Modified: 2013-07-22 20:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
3D: improve alignment of file numbers (1.66 KB, patch)
2013-07-20 19:19 UTC, Michael Catanzaro
none Details | Review
3D: improve alignment of file letters (1.66 KB, patch)
2013-07-20 19:20 UTC, Michael Catanzaro
rejected Details | Review
screenshot (347.95 KB, image/png)
2013-07-22 00:40 UTC, Adam Dingle
  Details
3D: improve alignment of file letters (2.00 KB, patch)
2013-07-22 13:25 UTC, Michael Catanzaro
committed Details | Review
Screenshot of attempt #2 (387.30 KB, image/png)
2013-07-22 13:30 UTC, Michael Catanzaro
  Details
screenshot (404.53 KB, image/png)
2013-07-22 15:51 UTC, Adam Dingle
  Details

Description Adam Dingle 2013-07-20 13:12:40 UTC
To see the problem, enable 3D view and board numbering.  Look at the letters "a" through "h" at the bottom of the board.  They look ragged: "a", "c" and "e" appear a bit higher than "b" and "d".  Instead, the letters should be aligned so that you could draw a straight line through the baselines of all these characters.
Comment 1 Michael Catanzaro 2013-07-20 19:19:14 UTC
Created attachment 249703 [details] [review]
3D: improve alignment of file numbers
Comment 2 Michael Catanzaro 2013-07-20 19:20:50 UTC
Created attachment 249704 [details] [review]
3D: improve alignment of file letters
Comment 3 Michael Catanzaro 2013-07-20 19:22:38 UTC
Comment on attachment 249703 [details] [review]
3D: improve alignment of file numbers

Adam, does this patch look good to you?
Comment 4 Adam Dingle 2013-07-22 00:39:51 UTC
I applied the patch and yes, this looks much better.  The only remaining problem is that part of the descender on the letter 'g' is clipped off.  (I'll attach a screenshot.)
Comment 5 Adam Dingle 2013-07-22 00:40:56 UTC
Created attachment 249759 [details]
screenshot
Comment 6 Adam Dingle 2013-07-22 00:47:21 UTC
As you can see in the screenshot, at the top of the board the letter 'g' is also cut off, and the letter 'b' touches the board which is different from how the 'b' at the bottom of the board looks.  I'm not sure if the intention is to create a 3D effect in which the chess squares are elevated above the surrounding margin.  If so, then maybe the letters at the top of the board appear OK (i.e. they extend below the squares of the chessboard), but the raised effect still doesn't look quite right to me overall.
Comment 7 Michael Catanzaro 2013-07-22 13:11:17 UTC
Review of attachment 249704 [details] [review]:

If you resize your window slowly, you'll see that at some window sizes, the bottom of the bottom 'g' is nearly there, but resizing just a bit, the bottom of the 'g' disappears.  So it looked good to me by bad luck.
Comment 8 Michael Catanzaro 2013-07-22 13:25:03 UTC
Created attachment 249798 [details] [review]
3D: improve alignment of file letters
Comment 9 Michael Catanzaro 2013-07-22 13:30:46 UTC
Created attachment 249799 [details]
Screenshot of attempt #2

Here's what I'm seeing now; it looks good to me, but the bottom of the top 'g' is still slightly over the edge of the board.  I think I'm content with this, but I'd like to see another screenshot from your end, since it looks like for you the portion of the 'g' overlapping the board disappears entirely.
Comment 10 Adam Dingle 2013-07-22 15:51:41 UTC
Created attachment 249813 [details]
screenshot

Here's a screenshot from my machine with this latest patch.  I think it looks pretty much like yours: the top 'g' overlaps the top of the board slightly.  I could certainly live with this.
Comment 11 Michael Catanzaro 2013-07-22 20:53:25 UTC
OK.  I might return to this later and try for better, but I can't think of anything else to try now that wouldn't be a hack, or make the letters too small.

Thanks for the report!
Comment 12 Michael Catanzaro 2013-07-22 20:54:50 UTC
Comment on attachment 249798 [details] [review]
3D: improve alignment of file letters

Attachment 249798 [details] pushed as e0889e8 - 3D: improve alignment of file letters