After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704530 - Array compared against 0
Array compared against 0
Status: RESOLVED FIXED
Product: libxml2
Classification: Platform
Component: general
git master
Other All
: Normal trivial
: ---
Assigned To: Daniel Veillard
libxml QA maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-19 08:47 UTC by Gaurav
Modified: 2013-07-22 06:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Gaurav 2013-07-19 08:47:09 UTC 
In file : https://git.gnome.org/browse/libxml2/tree/debugXML.c

Line no : 2949


if ((arg == NULL) || (arg[0] == 0))
		xmlGenericError(xmlGenericErrorContext,
                        "Write command requires a filename argument\n");


Here arg is an array. Comparing it to null ( arg==NULL) has no effect.

So, this comparison should be removed.
Comment 1 Daniel Veillard 2013-07-22 06:31:01 UTC 
Yup, useless code as the arg is allocated on the stack,

https://git.gnome.org/browse/libxml2/commit/?id=ccc9cf9276d9f603f01302da885155556d236b56

 thanks !

Daniel