GNOME Bugzilla – Bug 704505
decklink: add back property to select device
Last modified: 2013-07-22 13:33:33 UTC
Created attachment 249571 [details] [review] Patch to re-enable device selection in the decklink plugin The device property should be named differently according to the comments in the code. This caused the feature of selecting a device to be unavailable. Attached is a patch for the 1.0 branch to fix the problem.
Thanks for the patch. Any chance you could provide a patch in "git format-patch" format ? Basically make a git commit locally (after setting your name + e-mail properly with git), and then export it to a file with "git format-patch -1". That way we don't have to write the name + commit message, but can apply it directly.
Sure that shouldn't be a problem I'll look into it tonight.
Created attachment 249653 [details] [review] git format-patch
Should I make one for the 0.10 and 0.11 branches as well? Or is it possible to mutate these changes to those branches somehow?
No, thanks, 0.10 is not maintained any longer, and 0.11 was just a development branch that's been abandoned. There's only git master and the 1.0 stable branch now, and I'm sure the patch applies to both.
That's too bad I made the patch for 0.10 actually, because I'm using it through qt-gstreamer which is currently unable to work with 1.0 and all major Linux dists are still packaging it. Turned out that in the 1.0 branch another bit of code was disabled causing decklinksink not to be available at all. So another patch to re-enable the element is enclosed.
Created attachment 249665 [details] [review] Re-enable decklinksink element
> Turned out that in the 1.0 branch another bit of code was disabled causing > decklinksink not to be available at all. So another patch to re-enable the > element is enclosed. Thanks. I take it that means you have also tested the ported decklinksink a bit and it works at least somewhat? I think I left it disabled after porting it because I hadn't tested it at all.
Thanks, pushed both, also to 1.0 branch: commit 136aa4614e0db3056aadc70ffb993016b927ea7c Author: Youri Westerman <tetracon@gmail.com> Date: Fri Jul 19 23:42:12 2013 +0200 decklink: actually enable decklinksink https://bugzilla.gnome.org/show_bug.cgi?id=704505 commit f9898e42f6cd6fdab499a46d8c8d4e8d0f9af6fb Author: Youri Westerman <tetracon@gmail.com> Date: Fri Jul 19 20:09:28 2013 +0200 decklink: add "device-number" to select from multiple devices https://bugzilla.gnome.org/show_bug.cgi?id=704505