After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704475 - Remove gtk_dialog_run()
Remove gtk_dialog_run()
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: mouse
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Ondrej Holy
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-18 15:03 UTC by Bastien Nocera
Modified: 2013-07-30 11:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
replace dialog by warning (2.44 KB, patch)
2013-07-23 09:16 UTC, Ondrej Holy 		committed Details | Review

Description Bastien Nocera 2013-07-18 15:03:03 UTC 
It blocks the mainloop and would block other services (such as accessing anything over D-Bus). This needs to be removed.

mouse/gsd-mouse-manager.c:                        gtk_dialog_run (GTK_DIALOG (dialog));

The code isn't even that useful. Can't we check for mousetweaks earlier? Consider it a packaging bug instead.
Comment 1 Ondrej Holy 2013-07-23 09:16:47 UTC 
Created attachment 249871 [details] [review]
replace dialog by warning
Comment 2 Bastien Nocera 2013-07-24 15:24:12 UTC 
Review of attachment 249871 [details] [review]:

Looks fine.