After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704471 - loginDialog: avoid blinking user list when disable-user-list=true
loginDialog: avoid blinking user list when disable-user-list=true
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
unspecified
Other All
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-18 14:17 UTC by Ray Strode [halfline]
Modified: 2013-07-18 17:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
loginDialog: avoid blinking user list when disable-user-list=true (4.78 KB, patch)
2013-07-18 14:17 UTC, Ray Strode [halfline] 		committed Details | Review

Description Ray Strode [halfline] 2013-07-18 14:17:31 UTC 
Right now if disable-user-list is true we show it briefly, just so
that we can fade it out to the user entry.

This commit avoids the fade in that case.
Comment 1 Ray Strode [halfline] 2013-07-18 14:17:33 UTC 
Created attachment 249516 [details] [review]
loginDialog: avoid blinking user list when disable-user-list=true
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-07-18 17:03:06 UTC 
Review of attachment 249516 [details] [review]:

OK, with one nit.

::: js/gdm/loginDialog.js
@@ +451,3 @@
         this._userSelectionBox = new St.BoxLayout({ style_class: 'login-dialog-user-selection-box',
+                                                    vertical: true,
+                                                    visible: false});

Style nit: missing space before }
Comment 3 Ray Strode [halfline] 2013-07-18 17:08:42 UTC 
Attachment 249516 [details] pushed as e5e3f3c - loginDialog: avoid blinking user list when disable-user-list=true