After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704467 - Port to GAction
Port to GAction
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-18 14:08 UTC by Stefano Facchini
Modified: 2013-07-22 21:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Port page-switching to GAction (13.57 KB, patch)
2013-07-18 15:54 UTC, Stefano Facchini 		committed Details | Review
Port View menu to GAction (20.38 KB, patch)
2013-07-18 15:54 UTC, Stefano Facchini 		committed Details | Review
Port Refresh to GAction (5.49 KB, patch)
2013-07-18 15:54 UTC, Stefano Facchini 		committed Details | Review
Port process popup menu to GAction (30.78 KB, patch)
2013-07-18 15:54 UTC, Stefano Facchini 		none Details | Review
Port process popup menu to GAction (31.24 KB, patch)
2013-07-18 17:37 UTC, Stefano Facchini 		committed Details | Review

Description Stefano Facchini 2013-07-18 14:08:44 UTC 
GtkAction is being deprecated, along with its entourage (GtkUIManager etc). Everything needs to be ported to GAction. Patches coming...
Comment 1 Stefano Facchini 2013-07-18 15:54:14 UTC 
Created attachment 249535 [details] [review]
Port page-switching to GAction

The code is reworked to consistently make use of GAction and
GSettings.
Comment 2 Stefano Facchini 2013-07-18 15:54:17 UTC 
Created attachment 249536 [details] [review]
Port View menu to GAction

gsettings keys "show-tree" and "view-as" are renamed to
"show-dependencies" and "show-whose-processes", respectively.
Comment 3 Stefano Facchini 2013-07-18 15:54:20 UTC 
Created attachment 249537 [details] [review]
Port Refresh to GAction
Comment 4 Stefano Facchini 2013-07-18 15:54:24 UTC 
Created attachment 249538 [details] [review]
Port process popup menu to GAction
Comment 5 Stefano Facchini 2013-07-18 17:37:18 UTC 
Created attachment 249552 [details] [review]
Port process popup menu to GAction

Forgot to remove a prototype from a header file...
Comment 6 Robert Roth 2013-07-20 20:41:16 UTC 
Review of attachment 249535 [details] [review]:

Did you try Alt+1/2/3 for page switching? I see them declared, they did work in previous versions, but after this patch they don't work anymore. We wouldn't like to regress on accessibility shortcuts.
Comment 7 Stefano Facchini 2013-07-20 20:49:57 UTC 
(In reply to comment #6)
> Review of attachment 249535 [details] [review]:
> 
> Did you try Alt+1/2/3 for page switching? I see them declared, they did work in
> previous versions, but after this patch they don't work anymore. We wouldn't
> like to regress on accessibility shortcuts.

That's weird, they work just fine for me. Which version of GTK+ are you building against? (GTK+ master for me)

That said, I still can't have the other shortcuts (control+D etc.) working...
Comment 8 Robert Roth 2013-07-21 07:06:29 UTC 
I have built gsm with gtk 3.6.4 on Ubuntu, but in this case I'll try it  on Arch with the latest available version.
Comment 9 Robert Roth 2013-07-22 20:03:40 UTC 
Attachment 249535 [details] pushed as 2450d8a - Port page-switching to GAction
Attachment 249536 [details] pushed as d43c662 - Port View menu to GAction
Attachment 249537 [details] pushed as 1406c6b - Port Refresh to GAction
Attachment 249552 [details] pushed as 0e766b2 - Port process popup menu to GAction
Comment 10 Robert Roth 2013-07-22 21:18:40 UTC 
@Stefano Facchini: After adding the accelerators to the GtkApplication they do work again (meaning the ones that did not work for you, like dependencies and process actions), so it's OK to have this fixed.