After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704430 - Changes of css style results in incoherent drawings
Changes of css style results in incoherent drawings
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: st
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-18 00:10 UTC by Lionel Landwerlin
Modified: 2013-07-18 00:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
st-theme-node: reset paint state when theme node changes (1.24 KB, patch)
2013-07-18 00:11 UTC, Lionel Landwerlin
committed Details | Review

Description Lionel Landwerlin 2013-07-18 00:10:00 UTC
Following the changes to add paint states and my rebase of the box-shadow optimization, the code was still doing assumptions over when to reset cached textures. The current implementation assumes that if a paint state associated to a widget hasn't changed size its allocation, then we can just reuse it without any modification. This is obviously wrong if you've changed the css node attached to it.
Comment 1 Lionel Landwerlin 2013-07-18 00:11:00 UTC
Created attachment 249457 [details] [review]
st-theme-node: reset paint state when theme node changes
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-07-18 00:19:11 UTC
Review of attachment 249457 [details] [review]:

OK.
Comment 3 Lionel Landwerlin 2013-07-18 00:51:26 UTC
Pushed to master.