After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704383 - gupnp Python 3 compatibility
gupnp Python 3 compatibility
Status: RESOLVED FIXED
Product: GUPnP
Classification: Other
Component: gupnp
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-17 10:59 UTC by Bohuslav "Slavek" Kabrda
Modified: 2013-08-16 11:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Port gunpn-binding-tool to Python 3 (22.05 KB, patch)
2013-07-31 07:01 UTC, Bohuslav "Slavek" Kabrda 		accepted-commit_now Details | Review
Port gupnp-binding-tool to Python 3 (22.16 KB, patch)
2013-08-16 11:29 UTC, Jens Georg 		committed Details | Review

Description Bohuslav "Slavek" Kabrda 2013-07-17 10:59:41 UTC 
Hi, it seems that there is one Python script in gupnp (gupnp-binding-tool) that is not compatible with Python 3. Would you accept a patch that would fix this? It seems fairly simple to fix Python 3 incompatibilities here.
Thanks.
Comment 1 Jens Georg 2013-07-30 08:07:01 UTC 
Sure go ahead. I'd also accept a patch that removes it from the repository, tbh.

Fixing component, btw.
Comment 2 Bohuslav "Slavek" Kabrda 2013-07-31 07:01:42 UTC 
Created attachment 250520 [details] [review]
Port gunpn-binding-tool to Python 3

So, this is a patch to port gupnp-binding-tool to Python 3. It is really just an output of 2to3 (tested, seems to work ok). With this patch, gupnp-binding-tool will be compatible with Python 2.6+.
Comment 3 Jens Georg 2013-08-01 07:47:16 UTC 
Review of attachment 250520 [details] [review]:

Thanks!
Comment 4 Jens Georg 2013-08-16 11:29:25 UTC 
Created attachment 251819 [details] [review]
Port gupnp-binding-tool to Python 3

Fix issue with python2 where it would emit "()" instead of newlines.
Comment 5 Jens Georg 2013-08-16 11:29:44 UTC 
Attachment 251819 [details] pushed as 08ce5b8 - Port gupnp-binding-tool to Python 3