After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704378 - Switch to glib resource framework
Switch to glib resource framework
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-17 09:10 UTC by Stefano Facchini
Modified: 2013-07-20 20:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Switch to glib resource framework (39.13 KB, patch)
2013-07-17 09:10 UTC, Stefano Facchini 		none Details | Review
Switch to glib resource framework (39.13 KB, patch)
2013-07-20 20:25 UTC, Robert Roth 		committed Details | Review

Description Stefano Facchini 2013-07-17 09:10:00 UTC 
The glib resource framework has been around for a while now, let's port
system-monitor, too. Among benefits, it makes much easier to deal with .ui
files.
Comment 1 Stefano Facchini 2013-07-17 09:10:02 UTC 
Created attachment 249370 [details] [review]
Switch to glib resource framework
Comment 2 Robert Roth 2013-07-20 20:25:14 UTC 
The following fix has been pushed:
9f435d8 Switch to glib resource framework
Comment 3 Robert Roth 2013-07-20 20:25:18 UTC 
Created attachment 249706 [details] [review]
Switch to glib resource framework
Comment 4 Robert Roth 2013-07-20 20:30:08 UTC 
Thanks for the patch, reviewed it, done basic testing, works just fine, so have pushed it using git-bz ;), however as you can see it has reattached the patch (git bz push --fix=ticketno origin master).  I have checked the manpage but I don't see why the patch is attached. Do you happen to know how can I avoid readding the patch?
Comment 5 Stefano Facchini 2013-07-20 20:41:14 UTC 
The basic workflow for bugzilla bug XXXXXX shoud be something like

$ git bz apply XXXXXX

[testing...]

$ git bz push origin master

The --fix=XXXXXX flag should only be used when you have a local commit and you want to push and attach to the bug at the same time.

The other useful commands are

$ git bz attach XXXXXX HEAD
(or commit SHA number instead of HEAD)

$ git bz file product/component

Hope this helps! :)