After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704343 - Remove obsolete calls to JS_EnterLocalRootScope() and JS_LeaveLocalRootScope()
Remove obsolete calls to JS_EnterLocalRootScope() and JS_LeaveLocalRootScope()
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-16 17:55 UTC by sébastien lafargue
Modified: 2013-07-17 16:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove obsolete calls to JS_EnterLocalRootScope() and JS_LeaveLocalRootScope() (6.50 KB, patch)
2013-07-16 17:55 UTC, sébastien lafargue 		committed Details | Review

Description sébastien lafargue 2013-07-16 17:55:38 UTC 
Since SpiderMonkey 1.8.5, we no longer need to use this functions because of
Garbage collector conservative stack scanner
Comment 1 sébastien lafargue 2013-07-16 17:55:40 UTC 
Created attachment 249310 [details] [review]
Remove obsolete calls to JS_EnterLocalRootScope() and JS_LeaveLocalRootScope()

Since SpiderMonkey 1.8.5, we no longer need to use this functions because of
Garbage collector conservative stack scanner
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-07-16 17:59:36 UTC 
Review of attachment 249310 [details] [review]:

OK.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-07-16 18:00:01 UTC 
Review of attachment 249310 [details] [review]:

Whoops, meant to mark as ACN.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-07-17 16:33:40 UTC 
Attachment 249310 [details] pushed as 06e8b18 - Remove obsolete calls to JS_EnterLocalRootScope() and JS_LeaveLocalRootScope()