After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704342 - osvideosink: remove deprecated 'have-ns-view' functionality
osvideosink: remove deprecated 'have-ns-view' functionality
Status: RESOLVED DUPLICATE of bug 703753
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Mac OS
: Normal minor
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-16 17:26 UTC by Alexey Chernov
Modified: 2013-07-17 08:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Deprecated 'have-ns-view' logic was removed (4.63 KB, patch)
2013-07-16 17:26 UTC, Alexey Chernov 		none Details | Review
Copyright note update (3.86 KB, patch)
2013-07-16 17:28 UTC, Alexey Chernov 		none Details | Review

Description Alexey Chernov 2013-07-16 17:26:22 UTC 
As Andoni suggested in mailing-list, I removed 'have-ns-view' functionality for 1.x branch in osxvideosink as it's fully redundant and makes the code a little bit messy.
Comment 1 Alexey Chernov 2013-07-16 17:26:58 UTC 
Created attachment 249304 [details] [review]
Deprecated 'have-ns-view' logic was removed
Comment 2 Alexey Chernov 2013-07-16 17:27:54 UTC 
I also created a patch with copyright note of my employer. If it's appropriate and my refactoring would be considered useful, we'd be glad if this patch would be merged, too.
Comment 3 Alexey Chernov 2013-07-16 17:28:19 UTC 
Created attachment 249305 [details] [review]
Copyright note update
Comment 4 Tim-Philipp Müller 2013-07-16 17:33:55 UTC 
Duplicate of #703753 ?
Comment 5 Alexey Chernov 2013-07-16 21:20:29 UTC 
Hmm, seems to be. Didn't know it was already discussed.
So, I don't know. I didn't test it on any version so I can't say if it still works, so I'd prefer to remove it and forget it. But as it was already decided, so, reject, probably.
Comment 6 Sebastian Dröge (slomo) 2013-07-17 08:17:06 UTC 
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

*** This bug has been marked as a duplicate of bug 703753 ***