After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704297 - save dialog design issues
save dialog design issues
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
: 712770 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-07-15 21:38 UTC by William Jon McCann
Modified: 2013-12-09 11:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (17.85 KB, image/png)
2013-07-15 21:38 UTC, William Jon McCann 		Details

Description William Jon McCann 2013-07-15 21:38:48 UTC 
Created attachment 249248 [details]
screenshot

There are a few design issues with the save confirmation dialog.

1. The icon should be symbolic
2. The primary and secondary text should be left aligned with respect to each other
3. The icon should be top left aligned
4. The space on each side of the icon should be consistent. Currently, there is more on the right than the left.
5. The quotes aren't the correct quotes.
Comment 1 Ignacio Casal Quinteiro (nacho) 2013-07-16 07:59:30 UTC 
I'll push a branch today with the fixes. Although double tested on gedit 3.8 and it looks correctly aligned. I wonder when gtk+ will stop breaking gedit under our feet....
Comment 2 Ignacio Casal Quinteiro (nacho) 2013-07-16 08:02:56 UTC 
Pushed wip/closedlg which fixes some of the issues. Please double check
Comment 3 Ignacio Casal Quinteiro (nacho) 2013-07-16 08:06:16 UTC 
I see some problems though... while the label in gedit 3.8 is correctly aligned to the image, setting v/halign to start in the image, it makes the alignment off. I didn't touch the image space so feel free to change it. When closing several documents not sure if alignments are correct. Feel free to make the changes as you wish on that branch
Comment 4 William Jon McCann 2013-07-16 14:30:24 UTC 
FYI, 3.8 had the same issues here as in the screenshot I posted. I'll try the branch.
Comment 5 Ignacio Casal Quinteiro (nacho) 2013-07-19 16:32:33 UTC 
I think this should be fixed now. Feel free to reopen if there is something still left.
Comment 6 Ignacio Casal Quinteiro (nacho) 2013-12-09 11:44:27 UTC 
*** Bug 712770 has been marked as a duplicate of this bug. ***