After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704254 - Artist view - track titles are misaligned
Artist view - track titles are misaligned
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: High normal
: 3.10
Assigned To: gnome-music-maint
gnome-music-maint
3.10
Depends on:
Blocks:
 
 
Reported: 2013-07-15 14:31 UTC by Allan Day
Modified: 2013-07-17 13:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot with modifications (126.64 KB, image/png)
2013-07-15 14:31 UTC, Allan Day 		  Details
Screenshot (180.96 KB, image/png)
2013-07-16 17:06 UTC, Sai Suman Prayaga 		  Details
Attachment to the patch. (4.08 KB, patch)
2013-07-17 11:02 UTC, Sai Suman Prayaga 		needs-work Details | Review
Deleted the extra unused code. (3.78 KB, patch)
2013-07-17 13:12 UTC, Sai Suman Prayaga 		committed Details | Review
patch for ui fix in artistalbums. (3.82 KB, patch)
2013-07-17 13:16 UTC, Vadim Rutkovsky 		committed Details | Review

Description Allan Day 2013-07-15 14:31:36 UTC 
Created attachment 249204 [details]
screenshot with modifications

The track numbers should be left-aligned against the artist name above. The current ident looks untidy and wastes space.

The attached screenshot has the current state on the left and a modified image on the right.
Comment 1 Sai Suman Prayaga 2013-07-16 17:06:22 UTC 
Created attachment 249295 [details]
Screenshot

The tracks are left aligned to make space for the erroricon when the tracks are not playable, as shown in the attachment. If the spacing is reduced, there would be no space left for the erroricon and would look cluttered.
Comment 2 Sai Suman Prayaga 2013-07-17 11:02:59 UTC 
Created attachment 249395 [details] [review]
Attachment to the patch.

Changed the padding and fixed the ui.
Comment 3 Vadim Rutkovsky 2013-07-17 11:17:41 UTC 
Review of attachment 249395 [details] [review]:

Looks fine to me, please remove extra file from patch and I'll push it

::: data/Unsaved
@@ +1,1 @@
+<?xml version="1.0" encoding="UTF-8"?>

Please remove that from the patch
Comment 4 Sai Suman Prayaga 2013-07-17 13:12:05 UTC 
Created attachment 249402 [details] [review]
Deleted the extra unused code.
Comment 5 Vadim Rutkovsky 2013-07-17 13:15:58 UTC 
The following fix has been pushed:
23f4fc7 patch for ui fix in artistalbums.
Comment 6 Vadim Rutkovsky 2013-07-17 13:16:05 UTC 
Created attachment 249403 [details] [review]
patch for ui fix in artistalbums.

	deleted:    data/Unsaved 1.glade