After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704251 - Port alarm setup dialog to composite template
Port alarm setup dialog to composite template
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-07-15 14:03 UTC by Evgeny Bobkin
Modified: 2013-07-17 07:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Port alarm setup dialog to composite template (31.43 KB, patch)
2013-07-15 14:03 UTC, Evgeny Bobkin 		none Details | Review
patch proposal (31.46 KB, patch)
2013-07-16 14:14 UTC, Evgeny Bobkin 		committed Details | Review

Description Evgeny Bobkin 2013-07-15 14:03:15 UTC 
Please review the attached patch.
Comment 1 Evgeny Bobkin 2013-07-15 14:03:17 UTC 
Created attachment 249201 [details] [review]
Port alarm setup dialog to composite template
Comment 2 Paolo Borelli 2013-07-15 19:45:29 UTC 
Review of attachment 249201 [details] [review]:

I have not tested it, but it looks good to commit. Just a minor nitpick below to amend before pushing it

::: src/alarm.vala
@@ -255,2 +256,3 @@
 private class SetupDialog : Gtk.Dialog {
     private Utils.WallClock.Format format;
+	[GtkChild]

tabs vs spaces

(also on the lines below)
Comment 3 Evgeny Bobkin 2013-07-16 08:14:13 UTC 
And one thing I wanted to test additionally is the definition of local variables with the [GtkChild] attribute in the constructor of the AlarmSetupDialog.
Comment 4 Evgeny Bobkin 2013-07-16 14:14:09 UTC 
Created attachment 249274 [details] [review]
patch proposal
Comment 5 Evgeny Bobkin 2013-07-16 14:17:00 UTC 
(In reply to comment #2)
> Review of attachment 249201 [details] [review]:
> 
> I have not tested it, but it looks good to commit. Just a minor nitpick below
> to amend before pushing it
> 
> ::: src/alarm.vala
> @@ -255,2 +256,3 @@
>  private class SetupDialog : Gtk.Dialog {
>      private Utils.WallClock.Format format;
> +    [GtkChild]
> 
> tabs vs spaces
> 
> (also on the lines below)

Thanks. improved. With this patch we can get rid of the Gtk.Stock.CANCEL deprecation warnings.
Comment 6 Paolo Borelli 2013-07-16 18:40:22 UTC 
Review of attachment 249274 [details] [review]:

looks good