After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704192 - h264parse: unable to determine framerate
h264parse: unable to determine framerate
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-14 11:56 UTC by Matej Knopp
Modified: 2015-02-02 19:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Matej Knopp 2013-07-14 11:56:13 UTC 
When parsing vui timing info the following condition in h264parser.c is not true

    if (parse_vui_params && vui->fixed_frame_rate_flag &&
        sps->frame_mbs_only_flag && !vui->pic_struct_present_flag) {

Both frame_mbs_only_flag and !vui->pic_struct_present_flag are 0. Can anyone tell me what the check is for?

Sample file:

https://s3.amazonaws.com/MatejK/Samples/bbc1hd-freeviewhd-example.ts
Comment 1 Sebastian Dröge (slomo) 2013-07-15 08:22:52 UTC 
From what I saw from the code there's no relation between these two flags and knowing a framerate, and others confirmed... some more testing needed :)
Comment 2 Vincent Penquerc'h 2013-07-15 09:23:01 UTC 
Looking at the spec, I see no reason why frame_mbs_only_flag nor vui->pic_struct_present_flag should be used to determine whether to read those values. I've removed those two checks here but for master doesn't even try to parse the SPS (and thus doesn't even reach that check). Does it for you on that file ? I've just updated to latest git.
Comment 3 Matej Knopp 2013-07-15 10:48:12 UTC 
I tested this with revision from 3 days ago, don't t think there was anything committed that would affect this since then.

I have the parser output AVC, could that make a difference? There is bunch of stuff that needs to be ignored at the beginning of file until it reaches SPS, but the parser does that in bytestream->avc mode.
Comment 4 Vincent Penquerc'h 2015-02-02 16:19:35 UTC 
Testing now, that block is executed. Since the fields that were irrelevant are removed, and that framerate is detected, I think this can now be closed.
Comment 5 Tim-Philipp Müller 2015-02-02 19:02:48 UTC 
-> OBSOLETE (unless we know what fixed it or when it was fixed).