After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704178 - drop GtkStock
drop GtkStock
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-14 00:57 UTC by Yosef Or Boczko
Modified: 2013-07-19 13:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
background: drop GtkStock (1.18 KB, patch)
2013-07-14 01:04 UTC, Yosef Or Boczko 		committed Details | Review
color: drop GtkStock (1.89 KB, patch)
2013-07-14 01:04 UTC, Yosef Or Boczko 		committed Details | Review
network: drop GtkStock (3.83 KB, patch)
2013-07-14 01:05 UTC, Yosef Or Boczko 		committed Details | Review
online-accounts: drop GtkStock (1.93 KB, patch)
2013-07-14 01:05 UTC, Yosef Or Boczko 		committed Details | Review
bluetooth: drop GtkStock (1.10 KB, patch)
2013-07-14 01:05 UTC, Yosef Or Boczko 		committed Details | Review
printer: drop GtkStock (1.93 KB, patch)
2013-07-14 01:05 UTC, Yosef Or Boczko 		committed Details | Review
search: drop GtkStock (2.27 KB, patch)
2013-07-14 01:06 UTC, Yosef Or Boczko 		committed Details | Review
sound: drop GtkStock (1.07 KB, patch)
2013-07-14 01:06 UTC, Yosef Or Boczko 		committed Details | Review
wacom: drop GtkStock (934 bytes, patch)
2013-07-14 01:06 UTC, Yosef Or Boczko 		committed Details | Review
user-accounts: drop GtkStock (4.80 KB, patch)
2013-07-14 01:06 UTC, Yosef Or Boczko 		needs-work Details | Review
user-accounts: drop GtkStock (4.68 KB, patch)
2013-07-19 13:05 UTC, Yosef Or Boczko 		committed Details | Review

Description Yosef Or Boczko 2013-07-14 00:57:58 UTC 
See patches.
Comment 1 Yosef Or Boczko 2013-07-14 01:04:21 UTC 
Created attachment 249086 [details] [review]
background: drop GtkStock
Comment 2 Yosef Or Boczko 2013-07-14 01:04:49 UTC 
Created attachment 249087 [details] [review]
color: drop GtkStock
Comment 3 Yosef Or Boczko 2013-07-14 01:05:03 UTC 
Created attachment 249088 [details] [review]
network: drop GtkStock
Comment 4 Yosef Or Boczko 2013-07-14 01:05:20 UTC 
Created attachment 249089 [details] [review]
online-accounts: drop GtkStock
Comment 5 Yosef Or Boczko 2013-07-14 01:05:34 UTC 
Created attachment 249090 [details] [review]
bluetooth: drop GtkStock
Comment 6 Yosef Or Boczko 2013-07-14 01:05:48 UTC 
Created attachment 249091 [details] [review]
printer: drop GtkStock
Comment 7 Yosef Or Boczko 2013-07-14 01:06:02 UTC 
Created attachment 249092 [details] [review]
search: drop GtkStock
Comment 8 Yosef Or Boczko 2013-07-14 01:06:16 UTC 
Created attachment 249093 [details] [review]
sound: drop GtkStock
Comment 9 Yosef Or Boczko 2013-07-14 01:06:32 UTC 
Created attachment 249095 [details] [review]
wacom: drop GtkStock
Comment 10 Yosef Or Boczko 2013-07-14 01:06:46 UTC 
Created attachment 249096 [details] [review]
user-accounts: drop GtkStock
Comment 11 Bastien Nocera 2013-07-19 12:42:18 UTC 
Review of attachment 249086 [details] [review]:

Looks good.
Comment 12 Bastien Nocera 2013-07-19 12:42:40 UTC 
Review of attachment 249087 [details] [review]:

Looks good
Comment 13 Bastien Nocera 2013-07-19 12:43:12 UTC 
Review of attachment 249088 [details] [review]:

Looks good.
Comment 14 Bastien Nocera 2013-07-19 12:43:53 UTC 
Review of attachment 249089 [details] [review]:

Looks good.
Comment 15 Bastien Nocera 2013-07-19 12:44:18 UTC 
Review of attachment 249090 [details] [review]:

Looks good.
Comment 16 Bastien Nocera 2013-07-19 12:44:41 UTC 
Review of attachment 249091 [details] [review]:

Looks good.
Comment 17 Bastien Nocera 2013-07-19 12:45:03 UTC 
Review of attachment 249092 [details] [review]:

Looks good.
Comment 18 Bastien Nocera 2013-07-19 12:45:22 UTC 
Review of attachment 249093 [details] [review]:

Looks good.
Comment 19 Bastien Nocera 2013-07-19 12:45:36 UTC 
Review of attachment 249095 [details] [review]:

Looks good.
Comment 20 Bastien Nocera 2013-07-19 12:46:57 UTC 
Review of attachment 249096 [details] [review]:

::: panels/user-accounts/um-fingerprint-dialog.c
@@ +272,2 @@
         button = gtk_button_new_with_mnemonic (_("_Delete Fingerprints"));
+        gtk_button_set_image (GTK_BUTTON (button), gtk_image_new_from_icon_name ("edit-delete", GTK_ICON_SIZE_BUTTON));

This needs removing the GTK_STOCK_DELETE docs say:
GTK_STOCK_DELETE has been deprecated since version 3.10 and should not be used in newly-written code. Do not use an icon. Use label "_Delete".
Comment 21 Yosef Or Boczko 2013-07-19 13:05:02 UTC 
Created attachment 249626 [details] [review]
user-accounts: drop GtkStock
Comment 22 Bastien Nocera 2013-07-19 13:26:29 UTC 
Review of attachment 249626 [details] [review]:

Looks good.
Comment 23 Yosef Or Boczko 2013-07-19 13:32:39 UTC 
Review of attachment 249086 [details] [review]:

pushed as 27e12bb7b0b679fc21b6c5e21adb4ac6ed87ecb9 - background: drop GtkStock
Comment 24 Yosef Or Boczko 2013-07-19 13:33:25 UTC 
Review of attachment 249087 [details] [review]:

pushed as 972648fd5fa3cf1bdf1ab17e99d079ab6219a655 - color: drop GtkStock
Comment 25 Yosef Or Boczko 2013-07-19 13:33:26 UTC 
Review of attachment 249087 [details] [review]:

pushed as 972648fd5fa3cf1bdf1ab17e99d079ab6219a655 - color: drop GtkStock
Comment 26 Yosef Or Boczko 2013-07-19 13:34:08 UTC 
Review of attachment 249088 [details] [review]:

pushed as e611930dfb8d8d319f6e339a48d9de161e7dc42e - network: drop GtkStock
Comment 27 Yosef Or Boczko 2013-07-19 13:34:41 UTC 
Review of attachment 249089 [details] [review]:

pushed as a9f6f69f7029e8d00da6ce64baa3b1b33912aa36 - online-accounts: drop GtkStock
Comment 28 Yosef Or Boczko 2013-07-19 13:35:11 UTC 
Review of attachment 249090 [details] [review]:

pushed as 888db9b45382db0a5d1fdbb7f703ad2216d3cc41 - bluetooth: drop GtkStock
Comment 29 Yosef Or Boczko 2013-07-19 13:35:48 UTC 
Review of attachment 249091 [details] [review]:

pushed as d49a097b3e57d1d7a7f2e530c9357fc98ce70d5b - printer: drop GtkStock
Comment 30 Yosef Or Boczko 2013-07-19 13:36:21 UTC 
Review of attachment 249092 [details] [review]:

pushed as 6926cf08b9b1c8be0e0c207f85aa917ce2581db3 - search: drop GtkStock
Comment 31 Yosef Or Boczko 2013-07-19 13:36:47 UTC 
Review of attachment 249093 [details] [review]:

pushed as 4fc66a57fad8bca77fd091e8f2f772180726e13a - sound: drop GtkStock
Comment 32 Yosef Or Boczko 2013-07-19 13:37:08 UTC 
Review of attachment 249095 [details] [review]:

pushed as cf81bc227f1ff1784a5f5a04cc58f61786d8eb53 - wacom: drop GtkStock
Comment 33 Yosef Or Boczko 2013-07-19 13:37:33 UTC 
Review of attachment 249626 [details] [review]:

pushed as 0ca97710796874fd0ba29a07184c3c68f796ea08 - user-accounts: drop GtkStock