After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704164 - GtkSearchEntry: the contents is always cleared on icon-release
GtkSearchEntry: the contents is always cleared on icon-release
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-07-13 19:04 UTC by Sébastien Wilmet
Modified: 2013-07-15 10:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GtkSearchEntry: fix search_entry_clear_cb() (1.11 KB, patch)
2013-07-13 19:14 UTC, Sébastien Wilmet 		reviewed Details | Review

Description Sébastien Wilmet 2013-07-13 19:04:55 UTC 
When the icon-release signal is emitted on a GtkSearchEntry, the contents is always cleared. It should instead be cleared only if the icon-release is for the secondary icon. Because the primary icon can be used for another purpose (e.g. pop a menu with search options).

A patch is coming soon.
Comment 1 Sébastien Wilmet 2013-07-13 19:14:43 UTC 
Created attachment 249071 [details] [review]
GtkSearchEntry: fix search_entry_clear_cb()

When the icon-release signal is emitted on a GtkSearchEntry, the
contents is now cleared only if it's for the secondary icon. The primary
icon can be used for another purpose.
Comment 2 Ignacio Casal Quinteiro (nacho) 2013-07-15 10:20:21 UTC 
Review of attachment 249071 [details] [review]:

See the inline comment, fix it and feel free to push. This has been acked by Company on irc.

::: gtk/gtksearchentry.c
@@ +85,3 @@
 static void
+search_entry_clear_cb (GtkEntry             *entry,
+                       GtkEntryIconPosition  icon_pos)

add also the user_data that you removed
Comment 3 Sébastien Wilmet 2013-07-15 10:28:30 UTC 
Fixed and pushed.