GNOME Bugzilla – Bug 704163
[PATCH] shellDBus: Emit a PropertyChanged for OverviewActive
Last modified: 2014-11-13 18:18:26 UTC
I was going to add another DBus property to signal when the shell was done loading and was idle, and while implementing that I noticed we aren't emitting PropertyChanged for, well, any property. Let's fix OverviewActive. It's unfortunate it's so tedious to correctly implement a DBus property =/ --- js/ui/shellDBus.js | 15 ++++++++++++++- 1 files changed, 14 insertions(+), 1 deletions(-)
Created attachment 249070 [details] [review] 0001-shellDBus-Emit-a-PropertyChanged-for-OverviewActive.patch
Created attachment 290200 [details] [review] shellDBus: Emit a PropertyChanged for OverviewActive I was going to add another DBus property to signal when the shell was done loading and was idle, and while implementing that I noticed we aren't emitting PropertyChanged for, well, any property. Let's fix OverviewActive. It's unfortunate it's so tedious to correctly implement a DBus property =/
Review of attachment 290200 [details] [review]: ::: js/ui/shellDBus.js @@ +243,3 @@ + _checkOverviewVisibleChanged: function() { + if (Main.overview.visible !== this._cachedOverviewVisible) { The safe-guards in Overview should already make sure that ::showing and ::hidden are only emitted on actual Overview:visible changes, but OK - some extra checks don't hurt.
Attachment 290200 [details] pushed as 891f30f - shellDBus: Emit a PropertyChanged for OverviewActive