After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704162 - aacparse: Too verbose when parsing LOAS stream
aacparse: Too verbose when parsing LOAS stream
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 1.0.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-13 18:57 UTC by Matej Knopp
Modified: 2013-07-17 17:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to lower the logging level. (840 bytes, patch)
2013-07-13 18:57 UTC, Matej Knopp 		committed Details | Review

Description Matej Knopp 2013-07-13 18:57:38 UTC 
Created attachment 249069 [details] [review]
Patch to lower the logging level.

I've tested some LOAS/LATM streams and the parsing seems to be working fine, except for 

"More data ignored"

message printed for every frame, which doesn't seem necessary. The parser doesn't need to parse anything other than AudioSpecificConfig, which it (at least partially) does.
Comment 1 Sebastian Dröge (slomo) 2013-07-15 05:55:44 UTC 
commit ae92ea21a123519821a9fd37a330fc0f17774f57
Author: Matej Knopp <matej.knopp@gmail.com>
Date:   Sat Jul 13 20:56:26 2013 +0200

    aacparse: be less verbose when parsing LOAS streams
    
    https://bugzilla.gnome.org/show_bug.cgi?id=704162
Comment 2 Sebastian Dröge (slomo) 2013-07-15 05:56:19 UTC 
Do you know what this additional data is?
Comment 3 Matej Knopp 2013-07-15 06:29:09 UTC 
After audio_specific_config there is 
frame_length_type, frame_length (optional), other_data_present flag, other_data_length (optional), crc_present, crc (optional), payload_length and payload

I don't think the parser needs to parse any of these, unless it wants to convert between formats. The overall packet length is at the beginning after sync word, that should be enough.