After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704157 - GAction: add function for printing detailed names
GAction: add function for printing detailed names
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gapplication
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-07-13 17:10 UTC by Allison Karlitskaya (desrt)
Modified: 2013-07-13 17:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GAction: add function for printing detailed names (6.98 KB, patch)
2013-07-13 17:10 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2013-07-13 17:10:29 UTC 
See patch.
Comment 1 Allison Karlitskaya (desrt) 2013-07-13 17:10:30 UTC 
Created attachment 249067 [details] [review]
GAction: add function for printing detailed names

A counterpart for parsing of detailed actions into (name, target) pairs,
this new function prints them back.

We also add a new function to check for validity of action names.  Only
valid action names are allowed when printing.  Parsing accepts _some_
invalid names for backwards compatibility.
Comment 2 Michael Natterer 2013-07-13 17:20:25 UTC 
Irrelevant nitpicking:

g_strjoin ("::", action_name, str, NULL);

I would use g_strconcat() here for simply joining two strings with
a separator.
Comment 3 Allison Karlitskaya (desrt) 2013-07-13 17:44:25 UTC 
Attachment 249067 [details] pushed as c04a063 - GAction: add function for printing detailed names

Pushed with the suggested change -- I like it better this way too.