After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704154 - [Regression] KEY_UP behaves like PAGE_DOWN when viewing documents
[Regression] KEY_UP behaves like PAGE_DOWN when viewing documents
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-13 15:59 UTC by Germán Poo-Caamaño
Modified: 2013-07-14 11:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Germán Poo-Caamaño 2013-07-13 15:59:08 UTC 
I have not bisected it yet, but I get an odd behaviour in master when I use the arrow keys (UP) to navigate in a document.

KEY_UP has a similar behaviour than PAGE_DOWN.  I would expect the document moves up, but it does the opposite.
Comment 1 Germán Poo-Caamaño 2013-07-13 16:17:30 UTC 
The culprit seems to be
https://git.gnome.org/browse/evince/commit/?id=660b74110d2033268eb6a5477f5ced71e0d9a355
Comment 2 Germán Poo-Caamaño 2013-07-13 18:34:11 UTC 
The issue disappear with:

@@ -6225,7 +6225,6 @@ ev_view_class_init (EvViewClass *class)
         add_scroll_binding_keypad (binding_set, GDK_KEY_Down,  GDK_MOD1_MASK, GTK_SCROLL_STEP_UP, GTK_ORIENTATION_VERTICAL);
 	add_scroll_binding_keypad (binding_set, GDK_KEY_Page_Up, 0, GTK_SCROLL_PAGE_BACKWARD, GTK_ORIENTATION_VERTICAL);
 	add_scroll_binding_keypad (binding_set, GDK_KEY_Page_Down, 0, GTK_SCROLL_PAGE_FORWARD, GTK_ORIENTATION_VERTICAL);
-	add_scroll_binding_keypad (binding_set, GDK_KEY_Return, 0, GTK_SCROLL_PAGE_FORWARD, GTK_ORIENTATION_VERTICAL);
 	add_scroll_binding_keypad (binding_set, GDK_KEY_Return, GDK_SHIFT_MASK, GTK_SCROLL_PAGE_BACKWARD, GTK_ORIENTATION_VERTICAL);
         gtk_binding_entry_add_signal (binding_set, GDK_KEY_H, 0, "scroll", 2,
 				      GTK_TYPE_SCROLL_TYPE, GTK_SCROLL_STEP_BACKWARD,

But, the key Return does not scroll anymore. I do not know where the actual bug is.
Comment 3 Germán Poo-Caamaño 2013-07-13 19:30:20 UTC 
Debugging a little bit with gdb, it seems to me that after pressing key up the signal is emitted twice.  Once with GTK_SCROLL_BACKWARD and immediately after with GTK_SCROLL_PAGE_FORWARD.
Comment 4 Carlos Garcia Campos 2013-07-14 11:12:58 UTC 
My fault, fixed in git master now.