After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704123 - screenshot-config: make proper use of 'extern'
screenshot-config: make proper use of 'extern'
Status: RESOLVED FIXED
Product: gnome-screenshot
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-screenshot-maint
gnome-screenshot-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-12 17:44 UTC by Allison Karlitskaya (desrt)
Modified: 2013-07-12 19:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot-config: make proper use of 'extern' (1.47 KB, patch)
2013-07-12 17:44 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2013-07-12 17:44:02 UTC 
See patch.
Comment 1 Allison Karlitskaya (desrt) 2013-07-12 17:44:03 UTC 
Created attachment 249033 [details] [review]
screenshot-config: make proper use of 'extern'

Variables in header files should have 'extern' on them and be defined
from a single .c file, otherwise you get a copy of the variable every
time you #include the header.

-fcommon masks this problem, but building with -fno-common fails because
of it.
Comment 2 Colin Walters 2013-07-12 17:44:58 UTC 
Review of attachment 249033 [details] [review]:

Looks good!
Comment 3 Allison Karlitskaya (desrt) 2013-07-12 19:19:17 UTC 
Attachment 249033 [details] pushed as 9c53100 - screenshot-config: make proper use of 'extern'