GNOME Bugzilla – Bug 704095
Legacy tray icons not clickable in 3.9.4
Last modified: 2013-07-24 13:22:37 UTC
Click on such icon just closing the tray without any actions Steps to reproduce: 1. Open some app with legacy tray icon like skype or liferea 2. Open message tray and try to click on icon(any mouse button) 3. Tray is closing but no actions are triggered Expected result: Open app's context menu or show it focused(depending on application tray icon click handler)
Created attachment 249016 [details] [review] notificationDaemon: Fix clicks on legacy icons Jasper removed the ShellGlobal:stage-input-mode property after its "last" use was removed. Adapt the (hopefully) really last use of the property to the recent input changes.
patch works fine, thanks for fast feedback
Review of attachment 249016 [details] [review]: Whoops, I spotted this but forgot to fix it I guess. This will fix it after the stage window is unfocused, but that won't work in all cases. If you hit Ctrl+Alt+Tab to switch to the panel, then open the message tray and click on an item, then we'll drop the grab but not unfocus the stage window. I think the only proper fix is to have a callback or signal when we drop all our grabs.
(In reply to comment #3) > If you hit Ctrl+Alt+Tab to switch to the panel, then open the > message tray and click on an item, then we'll drop the grab but not unfocus the > stage window. If that's how it's supposed to work, we have another bug here ... > I think the only proper fix is to have a callback or signal when we drop all > our grabs. OK.
(In reply to comment #4) > (In reply to comment #3) > > If you hit Ctrl+Alt+Tab to switch to the panel, then open the > > message tray and click on an item, then we'll drop the grab but not unfocus the > > stage window. > > If that's how it's supposed to work, we have another bug here ... Hm, well Clutter doesn't seem to ignore NotifyGrabbed events, so the UngrabKeyboard would generate a FocusOut on the stage window with NotifyGrabbed, so what would happen is that when we lose the grab in that case, we'd see FocusOut then a FocusIn on the stage window. Clutter could change its mind in the future, so I'd prefer to see something more explicit.
Review of attachment 249016 [details] [review]: Managed to talk to ebassi about this. There's no reason to ignore NotifyGrabbed, so this is fine.
Attachment 249016 [details] pushed as 13170fb - notificationDaemon: Fix clicks on legacy icons