After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704055 - Build script changes stuff in gst bad common directories
Build script changes stuff in gst bad common directories
Status: RESOLVED DUPLICATE of bug 569015
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal minor
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-11 20:49 UTC by Jean-François Fortin Tam
Modified: 2013-07-12 14:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Jean-François Fortin Tam 2013-07-11 20:49:37 UTC 
It seems that gst-plugins-bad keeps changing common/ and win32/common/ (specifically win32/common/config.h  whenever I compile it)... If my understanding is correct, those are autogenerated and shouldn't be committed, or maybe there's something in the build system that touches versioned files?

This regularly blocks my automated "git pull --rebase" from working on modules such as gst-plugins-bad.
Comment 1 Sebastian Dröge (slomo) 2013-07-12 07:59:31 UTC 
This should only happen if someone forgot to commit win32/common/config.h after a release. common changes should not happen but also will not block git pull --rebase.

Is there a problem currently?
Comment 2 Tim-Philipp Müller 2013-07-12 09:11:14 UTC 
From your description there seem to be two issues here:

a) changes/new files in common/ - could you provide a list of files?

b) changes in win32/common/config.h - this is bug #569015 (something that's been done for other modules hasn't been done here yet - usually it's just after a version update, then you should just ask someone to commit it).
Comment 3 Nicolas Dufresne (ndufresne) 2013-07-12 13:34:14 UTC 
I still don't get why do we commit a generated file ?

(I same issue here, this file get modified by the build system causing git to think I have changed the code)
Comment 4 Tim-Philipp Müller 2013-07-12 13:59:16 UTC 
This file is there for non-autotools based builds (just like in all the other modules, you just don't notice it there because the bug I mentioned has been fixed).
Comment 5 Nicolas Dufresne (ndufresne) 2013-07-12 14:24:49 UTC 
Marking a a dup then

*** This bug has been marked as a duplicate of bug 569015 ***