GNOME Bugzilla – Bug 704015
More height-for-width fixes
Last modified: 2013-08-20 06:42:04 UTC
I knew there was another hfw workaround lurking around somewhere ...
Created attachment 248936 [details] [review] modalDialog: Request HEIGHT_FOR_WIDTH All our modal dialogs are given a fixed width and grow vertically as necessary. Set the request mode accordingly, so that wrapped labels are considered correctly during size request, and not only at allocation time (where they'll either take away from the padding or even cause the dialog to overflow).
Created attachment 248937 [details] [review] networkAgent: Remove height-for-width hack ClutterBoxLayout has proper height-for-width support, so make use of it.
Review of attachment 248936 [details] [review]: A comment summarizing the commit message would be appreciated. ::: js/ui/modalDialog.js @@ +80,2 @@ this.dialogLayout = new St.BoxLayout({ style_class: 'modal-dialog', vertical: true }); Why not in the property bag?
Review of attachment 248937 [details] [review]: OK.
(In reply to comment #3) > Why not in the property bag? Long line, old fart, 80-char terminal :-)
Attachment 248936 [details] pushed as 00ccbda - modalDialog: Request HEIGHT_FOR_WIDTH Attachment 248937 [details] pushed as c37c4d8 - networkAgent: Remove height-for-width hack