After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703997 - Couple of obvious fixes for St
Couple of obvious fixes for St
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: st
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-11 12:27 UTC by Lionel Landwerlin
Modified: 2013-07-13 07:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
st-theme-node: invalidate cached size when initializing paint state (810 bytes, patch)
2013-07-11 12:28 UTC, Lionel Landwerlin 		committed Details | Review
st-theme-node: fix obvious size comparison error (832 bytes, patch)
2013-07-11 12:29 UTC, Lionel Landwerlin 		committed Details | Review

Description Lionel Landwerlin 2013-07-11 12:27:56 UTC 
There is a wrong size comparison as well as the size of paint states not being reset on initialization.
Comment 1 Lionel Landwerlin 2013-07-11 12:28:38 UTC 
Created attachment 248920 [details] [review]
st-theme-node: invalidate cached size when initializing paint state
Comment 2 Lionel Landwerlin 2013-07-11 12:29:01 UTC 
Created attachment 248921 [details] [review]
st-theme-node: fix obvious size comparison error
Comment 3 Florian Müllner 2013-07-11 12:34:51 UTC 
Review of attachment 248921 [details] [review]:

Yup
Comment 4 Florian Müllner 2013-07-11 12:34:54 UTC 
Review of attachment 248921 [details] [review]:

Yup
Comment 5 Florian Müllner 2013-07-11 12:36:25 UTC 
Review of attachment 248920 [details] [review]:

LGTM
Comment 6 Lionel Landwerlin 2013-07-13 07:31:41 UTC 
Pushed to master.