After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703986 - magic character "g" in configure.ac
magic character "g" in configure.ac
Status: RESOLVED FIXED
Product: libgweather
Classification: Core
Component: general
3.9.x
Other Linux
: Normal normal
: future
Assigned To: libgweather-maint
libgweather-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-11 09:58 UTC by Evgeny Bobkin
Modified: 2013-07-14 12:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch proposal (1.17 KB, patch)
2013-07-11 12:09 UTC, Evgeny Bobkin
committed Details | Review

Description Evgeny Bobkin 2013-07-11 09:58:56 UTC
I came across https://git.gnome.org/browse/libgweather/tree/configure.ac#n10

$ git blame -L 10,10 configure.ac

has reported: 06538d35 (Jasper St. Pierre 2013-06-15 01:47:39 -0400 10) g


and this was it:

commit 06538d356f85f02d4f983a7e143b89939dd6eafc
Author: Jasper St. Pierre <jstpierre@mecheye.net>
Date:   Sat Jun 15 01:47:39 2013 -0400

    Update git.mk

diff --git a/Makefile.am b/Makefile.am
index e92209a..6d1ee34 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -9,22 +9,9 @@ EXTRA_DIST =           \
        MAINTAINERS
 
 MAINTAINERCLEANFILES = \
-       $(srcdir)/INSTALL \
-       $(srcdir)/aclocal.m4 \
-       $(srcdir)/compile \
-       $(srcdir)/config.guess \
-       $(srcdir)/config.h.in \
-       $(srcdir)/config.sub \
-       $(srcdir)/depcomp \
-       $(srcdir)/install-sh \
-       $(srcdir)/ltmain.sh \
-       $(srcdir)/missing \
-       $(srcdir)/mkinstalldirs \
-       `find "$(srcdir)" -type f -name Makefile.in -print` \
-       $(srcdir)/configure \
-       $(srcdir)/gtk-doc.make \
-       $(srcdir)/m4/gtk-doc.m4 \
-       $(srcdir)/m4/intltool.m4
+       $(GITIGNORE_MAINTAINERCLEANFILES_TOPLEVEL) \
+       $(GITIGNORE_MAINTAINERCLEANFILES_MAKEFILE_IN) \
+       $(GITIGNORE_MAINTAINERCLEANFILES_M4_LIBTOOL)
 
 CHANGELOG_GIT_RANGE = LIBGWEATHER_2_26_1..
 dist-hook:
diff --git a/configure.ac b/configure.ac
index 3600703..167a6ec 100644
--- a/configure.ac
+++ b/configure.ac
@@ -7,8 +7,7 @@ AC_PREREQ([2.64])
 
 AC_CONFIG_HEADERS([config.h])
 AC_CONFIG_MACRO_DIR([m4])
-AC_CONFIG_AUX_DIR([build-aux])
-
+g
 AM_INIT_AUTOMAKE([1.11 no-dist-gzip dist-xz tar-ustar])


moreover $ git status
# On branch master
# Untracked files:
#   (use "git add <file>..." to include in what will be committed)
#
#	ABOUT-NLS
#	INSTALL
#	build-aux/
#	config.rpath
#	gtk-doc.make
#	m4/

still shows crap


So, I would suggest to restore some of the removed items.
Comment 1 Evgeny Bobkin 2013-07-11 12:09:04 UTC
Created attachment 248919 [details] [review]
patch proposal
Comment 2 Giovanni Campagna 2013-07-13 15:51:19 UTC
Review of attachment 248919 [details] [review]:

Looks good!

I wonder why it still compiles fine with the g...
Comment 3 Evgeny Bobkin 2013-07-14 07:20:25 UTC
Thanks, committed, however I cannot change the patch status as committed, due to permissions lack in bugzilla.:-)
Comment 4 Giovanni Campagna 2013-07-14 12:06:06 UTC
Uhm... you should ask someone to add you to the developers group.
I mean, I could add you for libgweather, but it would be a stretch. Ask pbor to be in the gnome-clocks dev group.

(From there, you are also added to the global dev group, which gives you edit permissions on all bugs)