After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703930 - decoder: h264: improve robustness with missing or corrupted NALUs
decoder: h264: improve robustness with missing or corrupted NALUs
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 719412
 
 
Reported: 2013-07-10 09:26 UTC by congx.zhong
Modified: 2013-12-10 15:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-h264-reset-got_-sps-pps-when-corrupted-SPS-PPS-heade (1.83 KB, patch)
2013-07-10 09:26 UTC, congx.zhong
none Details | Review

Description congx.zhong 2013-07-10 09:26:50 UTC
Created attachment 248811 [details] [review]
0001-h264-reset-got_-sps-pps-when-corrupted-SPS-PPS-heade

skip stream parsing/decoding when there is corrupt sps/pps until a future correct one

    reset got_sps/got_pps when there are corrupted sps/pps header.
    
    this can stop (incorrect) slice parsing and frame decoding until there is a new valid one.

we can see this bug in fd.o
https://bugs.freedesktop.org/show_bug.cgi?id=57902
Comment 1 Gwenole Beauchesne 2013-11-29 05:41:54 UTC
Hi, I would like another "robustify" patch more in line with what we have for MPEG-2 and JPEG decoders. e.g. you state masks to check we have the required headers parsed prior to decoding for real.
Comment 2 Gwenole Beauchesne 2013-12-06 13:37:46 UTC
Changed summary to something more useful and on par with what needs to be done.
Comment 3 Gwenole Beauchesne 2013-12-10 15:17:34 UTC
Fixed in git master branch, while gracefully dropping invalid frames.
Comment 4 Gwenole Beauchesne 2013-12-10 15:18:22 UTC
commit 6fe54964bba22a415424839299ae5a2635f3d24e
Author: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Date:   Tue Dec 10 16:14:27 2013 +0100

    h264: improve robustness when packets are missing.
    
    Improve robustness when some expected packets where not received yet
    or that were not correctly decoded. For example, don't try to decode
    a picture if there was no valid frame headers parsed so far.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=703930