After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703917 - Flickr: Add item's title
Flickr: Add item's title
Status: RESOLVED FIXED
Product: gnome-online-miners
Classification: Applications
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Online Miners maintainer(s)
GNOME Online Miners maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-07-10 05:57 UTC by Marek Chalupa
Modified: 2013-07-19 12:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Store title into tracker (903 bytes, patch)
2013-07-10 05:57 UTC, Marek Chalupa 		committed Details | Review
flickr: Store the title as nie:title, not nfo:fileName (1.40 KB, patch)
2013-07-19 12:32 UTC, Debarshi Ray 		committed Details | Review

Description Marek Chalupa 2013-07-10 05:57:00 UTC 
Created attachment 248798 [details] [review]
Store title into tracker

It looks much more better in photos ;]
Comment 1 Debarshi Ray 2013-07-19 12:29:58 UTC 
Review of attachment 248798 [details] [review]:

You should put the URL to the bug in the commit message.

::: src/gom-flickr-miner.c
@@ +177,3 @@
+     job->cancellable, error,
+     job->datasource_urn, resource,
+     "nie:title", grl_media_get_title (entry->media));

We were already storing the title as nfo:fileName, which was wrong. So now that should be removed.

Ideally I would have split this into two patches:
- one that does s/nfo:fileName/nie:title/
- the other that moves the block of code earlier so that containers are also covered.

But it is not a blocker. ;-)
Comment 2 Debarshi Ray 2013-07-19 12:30:36 UTC 
Thanks for the patch. Committed after making the above adjustments.

commit f18a2531ae076792115386e64d317495c9c74607
Author: Marek Chalupa <mchalupa@redhat.com>
Date:   Thu Jul 4 08:50:55 2013 +0200

    flickr: Store the title as nie:title, not nfo:fileName
    
    Also, containers have titles too.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=703917
Comment 3 Debarshi Ray 2013-07-19 12:32:27 UTC 
Created attachment 249625 [details] [review]
flickr: Store the title as nie:title, not nfo:fileName

The final version that was committed.