After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703915 - Flickr: Creating hierarchy fails due to bad condition
Flickr: Creating hierarchy fails due to bad condition
Status: RESOLVED FIXED
Product: gnome-online-miners
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Online Miners maintainer(s)
GNOME Online Miners maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-07-10 05:53 UTC by Marek Chalupa
Modified: 2013-07-19 12:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Modified condition (911 bytes, patch)
2013-07-10 05:53 UTC, Marek Chalupa 		committed Details | Review

Description Marek Chalupa 2013-07-10 05:53:31 UTC 
Created attachment 248797 [details] [review]
Modified condition

The condition in processing entry is wrong.

When we run into a container when creating hierarchy, the parent is always NULL, so the condition is true and processing is ceased.
Comment 1 Debarshi Ray 2013-07-19 12:26:52 UTC 
Review of attachment 248797 [details] [review]:

You should add the URL to the bugzilla bug in the commit message.

::: src/gom-flickr-miner.c
@@ +110,3 @@
+  if (op_type == OP_CREATE_HIEARCHY
+      && entry->parent == NULL
+      && !GRL_IS_MEDIA_BOX (entry->media))

Could have been on the same line too.
Comment 2 Debarshi Ray 2013-07-19 12:27:33 UTC 
Thanks for the patch. Pushed after making the above adjustments.

commit 422b02fcd2d58a9cd59171470e07253839495220
Author: Marek Chalupa <mchalupa@redhat.com>
Date:   Thu Jul 4 08:44:20 2013 +0200

    flickr: Fix hierarchy creation
    
    Root containers don't have a parent, so only skip non-containers.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=703915