After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703857 - assertion failure after pressing Escape in save game alert
assertion failure after pressing Escape in save game alert
Status: RESOLVED FIXED
Product: gnome-chess
Classification: Applications
Component: General
git master
Other Linux
: Normal critical
: ---
Assigned To: Michael Catanzaro
gnome-chess-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-09 10:25 UTC by Adam Dingle
Modified: 2013-07-09 13:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix crash when new game dialog is deleted (943 bytes, patch)
2013-07-09 13:32 UTC, Michael Catanzaro 		committed Details | Review
Don't start new game if new game dialog is deleted (1.21 KB, patch)
2013-07-09 13:58 UTC, Michael Catanzaro 		committed Details | Review

Description Adam Dingle 2013-07-09 10:25:33 UTC 
To see the problem:

1. After at least one move has been played, press the New Game button.
2. gnome-chess will display a dialog "Save this game before starting a new one?"
3. Press Escape.

gnome-chess will abort, with this on the console:

ERROR:gnome-chess.c:4124:new_game_cb: assertion failed: (result == Gtk.ResponseType.NO)
Aborted (core dumped)
Comment 1 Michael Catanzaro 2013-07-09 13:07:39 UTC 
Reproduced in 3.9.4, but fortunately not 3.8.3.
Comment 2 Michael Catanzaro 2013-07-09 13:32:05 UTC 
The following fix has been pushed:
0c38c0d Fix crash when new game dialog is deleted

Thanks for your report!
Comment 3 Michael Catanzaro 2013-07-09 13:32:07 UTC 
Created attachment 248725 [details] [review]
Fix crash when new game dialog is deleted
Comment 4 Adam Dingle 2013-07-09 13:44:00 UTC 
I don't think this fix is correct.  With this change, Escape abandons the game.  Instead, it should cancel the dialog, leaving the game intact.  Reopening.
Comment 5 Michael Catanzaro 2013-07-09 13:58:11 UTC 
The following fix has been pushed:
c05a881 Don't start new game if new game dialog is deleted

That's correct; I did notice that but completely forgot to fix it.

This needs fixed in gnome-3-8 as well.
Comment 6 Michael Catanzaro 2013-07-09 13:58:13 UTC 
Created attachment 248728 [details] [review]
Don't start new game if new game dialog is deleted

Fixup for the previous commit