After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703821 - Pass --pidfile argument when invoking vpnc binary (patch attached)
Pass --pidfile argument when invoking vpnc binary (patch attached)
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: VPN: vpnc
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-07-08 20:24 UTC by Robby Workman
Modified: 2013-08-12 21:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
From git format-patch based on a4d87fc2bb41995e7d18522f80b8e76b0603073e (1.58 KB, patch)
2013-07-08 20:24 UTC, Robby Workman 		none Details | Review
enhanced from c1 (3.44 KB, patch)
2013-07-17 18:27 UTC, Robby Workman 		none Details | Review

Description Robby Workman 2013-07-08 20:24:54 UTC 
Created attachment 248659 [details] [review]
From git format-patch based on a4d87fc2bb41995e7d18522f80b8e76b0603073e

The vpnc binary seems to hardcode /var/run/vpnc/ as its pid dir,
which is created if vpnc is started using its included script
in $sysconfdir/vpnc/ - however, if it's started by NM-vpnc,
syslog shows "can't open pidfile /var/run/vpnc/pid for writing"

Fix that by using $localstatedir/run/NetworkManager/ as piddir.
Comment 1 Dan Williams 2013-07-09 15:18:11 UTC 
We'll want to suffix the pid file with the connection UUID and possibly some other unique timestamp too though, otherwise one nm-vpnc-service process would step on another when we support multiple concurrent VPN connections.
Comment 2 Pavel Simerda 2013-07-09 16:44:35 UTC 
+1
Comment 3 Robby Workman 2013-07-17 18:27:36 UTC 
Created attachment 249430 [details] [review]
enhanced from c1

After much help from Dan and many failed compiles, here's a better patch that addresses the issues in comment #1.
Comment 4 Dan Williams 2013-08-12 21:23:00 UTC 
Pushed with a small cleanup or two, thanks!