After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703811 - checkBox: Remove height-for-width hack
checkBox: Remove height-for-width hack
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 703810
Blocks:
 
 
Reported: 2013-07-08 18:07 UTC by Florian Müllner
Modified: 2013-08-20 06:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
checkBox: Remove height-for-width hack (1.69 KB, patch)
2013-07-08 18:08 UTC, Florian Müllner 		committed Details | Review
checkBox: Remove custom container implementation (5.12 KB, patch)
2013-07-11 15:30 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2013-07-08 18:07:55 UTC 
height-for-width now works properly with ClutterBoxLayout.
Comment 1 Florian Müllner 2013-07-08 18:08:00 UTC 
Created attachment 248647 [details] [review]
checkBox: Remove height-for-width hack

With the move to ClutterBoxLayout, height-for-width should now
work properly, so remove this old hack.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-07-08 18:12:05 UTC 
Review of attachment 248647 [details] [review]:

Nice.
Comment 3 Florian Müllner 2013-07-11 15:30:11 UTC 
Created attachment 248935 [details] [review]
checkBox: Remove custom container implementation

The only point of using a custom container here was to prevent StBoxLayout
from enforcing the wrong request mode based on the orientation. With that
issue fixed, we can simplify the checkbox widget significantly.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-07-11 16:55:45 UTC 
Review of attachment 248935 [details] [review]:

OK.
Comment 5 Florian Müllner 2013-08-20 06:41:25 UTC 
Attachment 248647 [details] pushed as c5dfc43 - checkBox: Remove height-for-width hack
Attachment 248935 [details] pushed as 777189d - checkBox: Remove custom container implementation