Created attachment 248631 [details] [review]
style: Fix focused app view controls

Moving from fixed width to horizontal padding for the app view control
buttons broke the focus style, in that buttons may change size on
keyboard focus changes. Fix this by using the correct horizontal padding
when focused.

Created attachment 248632 [details] [review]
modalDialog: Minor coding style fix

Created attachment 248633 [details] [review]
style: Fix extension list style in looking glass

No idea how this got unnoticed since forever, but code and stylesheet
didn't quite agree on the same name ...

Review of attachment 248632 [details] [review]:

Oh, there's lots of these around. I'd suggest you go around and fix them all if you want to fix them.

Review of attachment 248631 [details] [review]:

Why does the app view control have special padding on focus?

Review of attachment 248633 [details] [review]:

It probably went unnoticed because it looked OK, and nobody uses that panel of the looking glass anyhow.

(In reply to comment #5)
> Why does the app view control have special padding on focus?

So that the wider border doesn't affect the overall button size (it's a common pattern, we do the same in modal-dialog-button and elsewhere)

Attachment 248631 [details] pushed as c17f84c - style: Fix focused app view controls
Attachment 248632 [details] pushed as 0ae1f9f - modalDialog: Minor coding style fix
Attachment 248633 [details] pushed as bb4d430 - style: Fix extension list style in looking glass