GNOME Bugzilla – Bug 703775
ContactSearch is not clear when it is no supported
Last modified: 2013-07-08 11:40:03 UTC
For protocols where ContactSearch is not supported at all, the account is unsensitive in the combobox. I think that case is good enough. For XMPP however, it is supported, but not on all servers. Notably Google does not provide a contact search server and empathy does not provide an UI to define a server. In that case requesting the channel fails and empathy-contact-search-dialog just let the "Find" button unsensitive with not message to the user of what's going on. I don't think any user will type its own search server, that's probably why that UI is commented out in the code. But a clear message should be displayed to the user.
Created attachment 248602 [details] [review] EmpathyContactSearchDialog: factor out append_message_page()
Created attachment 248603 [details] [review] EmpathyContactSearchDialog: Add a "Not Supported" message page
Created attachment 248604 [details] [review] EmpathyContactSearchDialog: Set line wrap on message pages instead of ellipsize
Created attachment 248605 [details] [review] EmpathySearchContactDialog: Set search entry insensitive when search is not supported There is no point in letting user type something if the search button is insensitive anyway.
Review of attachment 248602 [details] [review]: ++
Review of attachment 248603 [details] [review]: ++
Review of attachment 248604 [details] [review]: ++
Review of attachment 248605 [details] [review]: ++
Merged in master.