After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703766 - Hide »comment« field by adding it to expert options
Hide »comment« field by adding it to expert options
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
3.4.x
Other Linux
: Normal enhancement
: ---
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2013-07-08 07:27 UTC by Paul Menzel
Modified: 2013-07-24 15:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pgp: Put the 'Comment' field in the advanced section of PGP key gen (9.33 KB, patch)
2013-07-09 07:56 UTC, Stef Walter 		committed Details | Review

Description Paul Menzel 2013-07-08 07:27:26 UTC 
Using Debian Wheezy with Seahorse 3.4.1-2 [1], I noticed that the »comment« field (Kommentar) is shown to the average user when creating a PGP key.

As Daniel Kahn Gillmor points out in his article »OpenPGP User ID Comments considered harmful« [1], these comments are normally not useful as most of what people put in there is deducible from the address itself. Additionally makes signing the key more cumbersome as these comments actually have to be verified too.

Therefore it would be awesome if you could hide that field by adding it to the expert section and even add a note, that normally people should not need that.

[1] http://ftp-master.metadata.debian.org/changelogs//main/s/seahorse/seahorse_3.4.1-2_changelog
[2] https://www.debian-administration.org/users/dkg/weblog/97
Comment 1 Stef Walter 2013-07-09 07:56:07 UTC 
Created attachment 248697 [details] [review]
pgp: Put the 'Comment' field in the advanced section of PGP key gen

Reasoning available here:
https://www.debian-administration.org/users/dkg/weblog/97
Comment 2 Stef Walter 2013-07-09 07:57:16 UTC 
Are you able to try out this patch and verify that it solves the problem?
Comment 3 Paul Menzel 2013-07-11 20:46:32 UTC 
Stef, thanks a lot for the prompt reply and patch. I am sorry for the late answer.


(In reply to comment #2)
> Are you able to try out this patch and verify that it solves the problem?

I am going to try that on Sunday. Thanks a lot again.
Comment 4 Paul Menzel 2013-07-17 10:27:08 UTC 
(In reply to comment #3)
> Stef, thanks a lot for the prompt reply and patch. I am sorry for the late
> answer.
> 
> 
> (In reply to comment #2)
> > Are you able to try out this patch and verify that it solves the problem?
> 
> I am going to try that on Sunday. Thanks a lot again.

I am sorry for the late reply. I successfully tested your patch by applying it to the gnome-3-8 branch and building Seahorse from it. The comment field is correctly hidden under the advanced options. This should be enough to discourage its use, though I have no idea how the people use it and what guides they follow and what these say.

Stef, thanks a lot again for the patch!
Comment 5 Stef Walter 2013-07-24 15:55:31 UTC 
Attachment 248697 [details] pushed as 1dd288f - pgp: Put the 'Comment' field in the advanced section of PGP key gen