After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703748 - Clearing the Full Name leaves 1 character in Username field
Clearing the Full Name leaves 1 character in Username field
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: Ondrej Holy
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-07 16:47 UTC by melchiaros
Modified: 2013-08-15 07:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
scrrenshot: account creation dialog - not wiped out "a" (591.58 KB, image/png)
2013-07-07 16:47 UTC, melchiaros
  Details
username generation fix (885 bytes, patch)
2013-07-23 14:38 UTC, Ondrej Holy
reviewed Details | Review
username generation fix (1.63 KB, patch)
2013-08-13 12:38 UTC, Ondrej Holy
committed Details | Review

Description melchiaros 2013-07-07 16:47:29 UTC
Created attachment 248553 [details]
scrrenshot: account creation dialog - not wiped out "a"

This here is the upstream repoport from:

https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1198683

The header of the report will be copied here

----------------------------------------------(launchpad report):

In the user managment component of the control center the possibility exist to create a new user.

Doing this an popup comes up that asks for the type of user account, the full name and the user name.

On giving a name in the full name section the user name section is filled with the same name automatically.

So long so correct.

On realizing a typo a user may whant to whipe out again the names.

Doing this in the full name field cuases also an automatically wiping out of the name in the user name field.

So, long also correct.

The issue is, that one letter keeps in the user name fild, even when the full name field is wiped out complete.

[A screenshot will be attached]

On user account creation not exact treating of the keystrokes may lead to a non working account system. The code there should be get some love.

Steps to reproduce:
1.Start system configuration -> user -> unlock -> create new account
2.Give in the full name field "Angela"
3.See the automatically filling of the filed user name with "angela"
4.Wipe out "Angela" in the full name field
5.See the automatically wiping out in the user filed with the exception of an kept "a"(see screenshot)

Expected:

The user account creating must be teached to handle every user input with care. Also the automatically helps must do their jobs with care.

ProblemType: Bug
DistroRelease: Ubuntu 13.04
Package: gnome-control-center 1:3.6.3-0ubuntu24.1
ProcVersionSignature: Ubuntu 3.8.0-26.38-generic 3.8.13.2
Uname: Linux 3.8.0-26-generic x86_64
NonfreeKernelModules: fglrx
ApportVersion: 2.9.2-0ubuntu8.2
Architecture: amd64
Date: Sun Jul 7 17:25:14 2013
ExecutablePath: /usr/bin/gnome-control-center
InstallationDate: Installed on 2013-01-13 (175 days ago)
InstallationMedia: Ubuntu 12.10 "Quantal Quetzal" - Release amd64 (20121017.5)
MarkForUpload: True
SourcePackage: gnome-control-center
UpgradeStatus: Upgraded to raring on 2013-04-18 (79 days ago)
usr_lib_gnome-control-center:
 activity-log-manager-control-center 0.9.4-0ubuntu6.1
 deja-dup 26.0-0ubuntu1
 gnome-control-center-signon 0.1.6bzr13.04.05-0ubuntu1.1
 gnome-control-center-unity 1.3daily13.06.19~13.04-0ubuntu1
 indicator-datetime 12.10.3daily13.03.26-0ubuntu1
Comment 1 Ondrej Holy 2013-07-23 14:38:06 UTC
Created attachment 249898 [details] [review]
username generation fix
Comment 2 Stef Walter 2013-08-08 13:12:04 UTC
Review of attachment 249898 [details] [review]:

Does this mean there's an empty drop down item after the user clears the name field? I realize this is minor, but do you think a better approach might be to just return FALSE from generate_name_choices, and clear the combo box based on that?
Comment 3 Ondrej Holy 2013-08-13 12:38:55 UTC
Created attachment 251472 [details] [review]
username generation fix

(In reply to comment #2)
> Review of attachment 249898 [details] [review]:
> 
> Does this mean there's an empty drop down item after the user clears the name
> field? I realize this is minor, but do you think a better approach might be to
> just return FALSE from generate_name_choices, and clear the combo box based on
> that?

Thank you for the review. You are right, I didn't realize that empty combobox should have the unsensitive button at the right side.
Comment 4 Stef Walter 2013-08-15 06:55:08 UTC
Review of attachment 251472 [details] [review]:

Looks good.