After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703735 - QtGStreamer cmake should fail on unsupported GStreamer and GLib versions
QtGStreamer cmake should fail on unsupported GStreamer and GLib versions
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: qt-gstreamer
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-07 11:38 UTC by Jens Georg
Modified: 2018-05-04 13:48 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jens Georg 2013-07-07 11:38:08 UTC
QtGStreamer head needs functions from 0.10.36 such as gst_discoverer_audio_info_get_language but cmake doesn't fail if only 0.10.35 can be found.

Same for GLib, it uses G_TYPE_ERROR from GLib >= 2.26 for example but happily accepts versions below that and fails during compilation later.
Comment 1 Benjamin Federau 2014-08-29 16:23:47 UTC
The same with QtGStreamer based on GStreamer 1.x. 

basedelegate.cpp:184 uses g_clear_pointer() which is not present in GLib version < 2.34

see http://cgit.freedesktop.org/gstreamer/qt-gstreamer/commit/?id=b3e587a7671d3d3d5b94f344a4e785023f31cef6
Comment 2 Tim-Philipp Müller 2018-01-23 19:59:50 UTC
Could someone with cmake-fu please make a patch for this then? Can't be hard hopefully.

I tried, but it doesn't actually stop or print an error when the version requirement isn't met, so I was probably missing something.
Comment 3 George Kiagiadakis 2018-05-04 13:48:48 UTC
Hmm, this is a bit of a pain because it needs quite some code to be added in FindGLIB2.cmake, similar to FindGStreamer.cmake: 102-141 ... Or find some other project that has a copy of that file and see if they have implemented version checks and copy them over.

I don't find it that important, tbh. There are more important things to work on in qt-gstreamer, if anyone wants to continue its development.