After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703732 - Unnecessary localdir override in configure.ac
Unnecessary localdir override in configure.ac
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
3.10.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
: 703733 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-07-07 11:13 UTC by Evgeny Bobkin
Modified: 2015-06-11 08:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch proposal (779 bytes, patch)
2013-07-07 11:36 UTC, Evgeny Bobkin 		committed Details | Review

Description Evgeny Bobkin 2013-07-07 11:13:56 UTC 
If there is no explicit reason for that, please do not overwrite the localedir variable in the configure.ac

it's already set to correct value by default

taken out from:
http://www.gnu.org/software/gettext/manual/html_node/src_002fMakefile.html 

Note that @datadir@ defaults to ‘$(prefix)/share’, thus $(localedir) defaults to ‘$(prefix)/share/locale’.

Moreover $(DATADIRNAME) is not set by inltool on Gentoo and many other distributions. Hence, the locale related files are installed incorrectly.

So, there is no need for those two lines:

localedir='$(prefix)/$(DATADIRNAME)/locale'
AC_SUBST(localedir)
Comment 1 Pacho Ramos 2013-07-07 11:32:18 UTC 
*** Bug 703733 has been marked as a duplicate of this bug. ***
Comment 2 Evgeny Bobkin 2013-07-07 11:36:32 UTC 
Created attachment 248542 [details] [review]
patch proposal
Comment 3 Matthew Barnes 2013-07-07 12:25:10 UTC 
Looks fine to me and distcheck still passes with it.  Thanks for the patch!

Committed for Evolution 3.9.4 and 3.8.4:

https://git.gnome.org/browse/evolution/commit/?id=4e5e734ed208c87020a6846b41dd72b5e8088525

https://git.gnome.org/browse/evolution/commit/?h=gnome-3-8&id=7303bb3633d919aa3eecb1f85ef56aa0b97bd9df
Comment 4 Milan Crha 2015-06-11 08:29:16 UTC 
I made the same change for evolution-ews and evolution-mapi, for 3.16.4+ and 3.17.3+.