After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703649 - Simplify PhotosDlnaRenderer initialization
Simplify PhotosDlnaRenderer initialization
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-07-05 12:45 UTC by Emanuele Aina
Modified: 2013-07-19 12:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dlna-renderer: Simplify async initialization code (8.21 KB, patch)
2013-07-05 12:45 UTC, Emanuele Aina 		committed Details | Review
dlna-renderer: Use the default impl for GAsyncInitable::init_finish() (1.50 KB, patch)
2013-07-05 12:46 UTC, Emanuele Aina 		committed Details | Review

Description Emanuele Aina 2013-07-05 12:45:56 UTC 
It occurred to me that the way I handled the initialization GTask was
completely bogus. :/

These patches fix it making the code is simpler and a bit shorter.
Comment 1 Emanuele Aina 2013-07-05 12:45:59 UTC 
Created attachment 248450 [details] [review]
dlna-renderer: Simplify async initialization code

Pass the GTask as callback data as $DEITY intended instead of our
instance, avoiding the current circular references mess.
Comment 2 Emanuele Aina 2013-07-05 12:46:04 UTC 
Created attachment 248451 [details] [review]
dlna-renderer: Use the default impl for GAsyncInitable::init_finish()

It is less code for us and also more correct as it also handle the old
compatibility case where the GAsyncResult is a GSimpleAsyncResult and
not a GTask.
Comment 3 Debarshi Ray 2013-07-19 12:54:24 UTC 
Thanks for the patches!