Created attachment 248374 [details] [review]
user-accounts: Use Enter key on password dialog

This allows users to use the enter key on the password setting dialog to complete the action.

Review of attachment 248374 [details] [review]:

It would be better to define accelerator for "ok-button" or use something else to be able complete dialog from whatever widget (not only from verify-entry)...

e.g. <accelerator key="Return" signal="activate"/>

::: panels/user-accounts/um-password-dialog.c
@@ +609,3 @@
         g_signal_connect (widget, "notify::text",
                           G_CALLBACK (verify_entry_changed), um);
+        g_signal_connect (widget, "activate",

There should to be g_signal_connect_after instead.

*** Bug 661568 has been marked as a duplicate of this bug. ***

See gtk_widget_grab_default().

Created attachment 248722 [details] [review]
user-accounts: Use Enter key on password dialog

Thanks Ondrej and Bastien, it seems the default widget was set correctly, I just had to enable the "activates-default" property for the desired GtkEntries to make this work; revised patch adds "ok-button" accelerator to all text entry widgets.

Review of attachment 248722 [details] [review]:

It looks good to me. Please commit to gnome-3-8 and master.

Created attachment 248756 [details] [review]
user-accounts: Use Enter key on password dialog

This is the same patch (attachment 248722 [details] [review]) rebased on master.

Thanks Pushed

gnome-3-8 796d524166620d5975def9c7c6aa269e2ed1166e
master ab650efdd78c7ef23da035a95e7b9380683862c7

(In reply to comment #8)
> Thanks Pushed
> 
> gnome-3-8 796d524166620d5975def9c7c6aa269e2ed1166e

When will a new 3.8.x version including this and all the fixes since last bump be released? Thanks a lot for the info :)

> master ab650efdd78c7ef23da035a95e7b9380683862c7