After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703606 - GtkPlacesSidebar should use g_themed_icon_new_with_default_fallbacks()
GtkPlacesSidebar should use g_themed_icon_new_with_default_fallbacks()
Status: RESOLVED NOTGNOME
Product: gtk+
Classification: Platform
Component: .General
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 707895
 
 
Reported: 2013-07-04 12:35 UTC by Cedric Bosdonnat
Modified: 2013-09-12 23:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
how it looks here (82.35 KB, image/png)
2013-07-04 12:35 UTC, Cedric Bosdonnat 		Details

Description Cedric Bosdonnat 2013-07-04 12:35:33 UTC 
Created attachment 248371 [details]
how it looks here

Steps to reproduce:
  * Create a new mail
  * Add an attachment

Actual result: the file picker is displayed with an empty list of places on the
left
Expected result: the file picker displayed with the usual places on the left
Comment 1 Frederic Crozat 2013-07-04 12:41:01 UTC 
confirming on 3.9.3
Comment 2 Matthew Barnes 2013-07-04 17:03:58 UTC 
Works fine for me with Evolution 3.9.3 and an older GTK+.

Evolution has no control over the Places side bar anyway; the file chooser dialog is a stock GTK+ widget.  There's been a lot of GTK+ regressions as of late.  Try downgrading your GTK+ to a stable version.  Let me know how it goes.
Comment 3 Frederic Crozat 2013-07-08 12:54:36 UTC 
confirming, it works fine with evolution 3.9.3 + gtk 3.6.4 but break with gtk 3.9.0 or 3.9.3.
Comment 4 Matthew Barnes 2013-07-08 13:11:53 UTC 
I'm already bisecting gtk3 for another regression; I'll try and hit this too.
Comment 5 Matthew Barnes 2013-07-08 15:28:26 UTC 
I think I see what's going on.

The new GtkPlacesSidebar is using symbolic icon names, but it's creating GIcons with g_themed_icon_new() instead of g_themed_icon_new_with_default_fallbacks(), which would fall back to the colorful icons if symbolic icons aren't available.  

I bet you could reproduce this with gtk3-demo via the "Pickers" test.

Reassigning.
Comment 6 Frederic Crozat 2013-07-08 15:33:37 UTC 
(In reply to comment #5)
> I bet you could reproduce this with gtk3-demo via the "Pickers" test.

Just tested and it works fine with gtk3-demo from gtk+ 3.9.3 ..
Comment 7 Frederic Crozat 2013-09-10 14:15:26 UTC 
reopening, the bug is back in evolution (3.9.90), but not in gtk3-demo, with gtk+ 3.9.12
Comment 8 Matthias Clasen 2013-09-11 02:20:52 UTC 
nothing to do with GtkPlacesSidebar at this point, we are using fallbacks there.
Comment 9 Matthew Barnes 2013-09-12 23:47:24 UTC 
*** Bug 707895 has been marked as a duplicate of this bug. ***