After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703565 - network: Fix a recursion issue when updating VPN
network: Fix a recursion issue when updating VPN
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-03 17:48 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-07-03 17:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
network: Fix a recursion issue when updating VPN (3.65 KB, patch)
2013-07-03 17:48 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-07-03 17:48:35 UTC
_updateIcon should not attempt to sync any active connections, as the
icon-changed signal can be emitted in response to something done during
_syncActiveConnection. In the case of VPN, removeActiveConnection would
cause an icon-changed signal to be emitted immediately, but the state
would not be updated, causing us to call removeActiveConnection over and
over.

Explicitly sync all active connections when we know it needs to be done,
and simply make _updateIcon synchronize with the current device's icon.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-07-03 17:48:37 UTC
Created attachment 248339 [details] [review]
network: Fix a recursion issue when updating VPN
Comment 2 drago01 2013-07-03 17:53:40 UTC
Review of attachment 248339 [details] [review]:

Looks good.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-07-03 17:55:36 UTC
Attachment 248339 [details] pushed as ccba18a - network: Fix a recursion issue when updating VPN