After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703521 - Enabling "Remote control" also enables password box even if "Require Password" is OFF
Enabling "Remote control" also enables password box even if "Require Password...
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Sharing
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-03 09:25 UTC by celine.LEGUAY
Modified: 2013-09-17 19:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gnome-control-center_sharpassgrid.patch (987 bytes, patch)
2013-08-20 08:38 UTC, manuel.BACHMANN@eurogiciel.fr
none Details | Review
sharing: prevent incorrect sensitivity of the screen sharing password entry (1.37 KB, patch)
2013-09-17 15:38 UTC, Thomas Wood
committed Details | Review

Description celine.LEGUAY 2013-07-03 09:25:07 UTC
User can notice that enabling "Remote Control" will also enable the password box, even if the "Require Password" is OFF
Steps :
1. Boot 
2. Go to settings - sharing
3. Press on screen sharing
4. Enable "Remove view" and "Remote control"
5. Observe that "Password" box is active now, but "Require password" is off
6. Type a password in the box
7. Connect to the vino server on localhost
8. Observe password in useless, observe that password box should be grayed out till "Require password" is ON!
Expected outcome
Password box is greyed out until "Require password" is ON
Actual outcome
Enabling "Remote Control" also enables a useless box
Comment 1 manuel.BACHMANN@eurogiciel.fr 2013-08-20 08:38:58 UTC
Created attachment 252345 [details] [review]
gnome-control-center_sharpassgrid.patch

Please consider the attached patch, which fixes this behavior on Fedora 19 and OpenSUSE variants.

The fix is in gnome-control-center, and not vino itself, so it may be necessary to recategorize the bug.
Comment 2 Thomas Wood 2013-09-17 15:38:06 UTC
Created attachment 255113 [details] [review]
sharing: prevent incorrect sensitivity of the screen sharing password entry

Attachment 252345 [details] no longer applies to master. This is a slightly different patch that also fixes this issue.
Comment 3 Rui Matos 2013-09-17 19:13:14 UTC
Review of attachment 255113 [details] [review]:

yes
Comment 4 Rui Matos 2013-09-17 19:23:36 UTC
Attachment 255113 [details] pushed as 3e0235f - sharing: prevent incorrect sensitivity of the screen sharing password entry